workflow(ci) - seperate steps #55
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the CI workflow to separate concerns into distinct jobs, enhancing clarity and modularity.
- Introduces a new "setup" job to output the Python version.
- Creates a dedicated "install" job for caching purposes.
- Adds a "test" job that sets up Python and runs dependency installation and tests.
Comments suppressed due to low confidence (1)
.github/workflows/ci.yml:41
- [nitpick] The caching step is placed in a separate job from dependency installation, which results in duplicated checkout and installation steps. Consider merging caching and dependency installation into a single job to streamline the workflow and improve efficiency.
- name: Cache virtualenv or PDM cache (optional)
.github/workflows/ci.yml
Outdated
| - name: Set up Python | ||
| uses: actions/setup-python@v5 | ||
| with: | ||
| python-version: "3.13" |
There was a problem hiding this comment.
[nitpick] Consider using the output from the 'setup' job (e.g., ${{ needs.setup.outputs.python-version }}) to configure the Python version dynamically instead of hardcoding '3.13', ensuring consistency across the workflow.
Suggested change
| python-version: "3.13" | |
| python-version: ${{ needs.setup.outputs.python-version }} |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Storm PR Checklist
Please confirm that your PR satisfies the following requirements:
make test,make lint, etc.)📦 Type of Change
🔍 Current Behavior
Issue Number: N/A
🚀 New Behavior
📝 Additional Information