10000 Fix User methods to use correct Primary Key [2.x] by bajtos · Pull Request #3129 · strongloop/loopback · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix User methods to use correct Primary Key [2.x] #3129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 23, 2017
Merged

Fix User methods to use correct Primary Key [2.x] #3129

merged 1 commit into from
Jan 23, 2017

Conversation

bajtos
Copy link
Member
@bajtos bajtos commented Jan 23, 2017 •
edited
Loading

Description

Do not use hard-coded "id" property name, call idName() to get the name of the PK property.

cc @ariskemper

Related issues

Checklist

  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style
    guide

@ariskemper @bajtos
Fix User methods to use correct Primary Key
5e7e7ca 
Do not use hard-coded "id" property name, call `idName()` to get the
name of the PK property.
@bajtos bajtos self-assigned this Jan 23, 2017
@bajtos bajtos added the review label Jan 23, 2017
@bajtos bajtos merged commit b2a0028 into 2.x Jan 23, 2017
@bajtos bajtos removed the review label Jan 23, 2017
@bajtos bajtos deleted the backport/fix-user-id branch January 23, 2017 09:59
@bajtos bajtos changed the title Fix User methods to use correct Primary Key Fix User methods to use correct Primary Key [2.x] Jan 23, 2017
This was referenced Jun 6, 2021
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bajtos bajtos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bajtos @ariskemper
0