Fix: Preserve deeply nested schemas #133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zastrowm
reviewed
May 28, 2025
3 tasks
|
hi @lukehau my sincerest apologies, i did not mean to overwrite the changes on your branch. i was attempting to clone, rebase and approve the changes and go ahead and merge them. if you would like, feel free to update the PR with you as the sole author and committer, else i'm more than happy to merge - the changes do indeed look good to me. |
jer96
approved these changes
Jun 3, 2025
|
All good @jer96 - feel free to merge. As long as I still get a phonetool award or something in the future 😉 |
zastrowm
approved these changes
Jun 5, 2025
15 tasks
Unshure
pushed a commit
to Unshure/sdk-python
that referenced
this pull request
Jul 2, 2025
* Preserve deeply nested schemas * Refactor schema tests to assert entire structure --------- Authored-by: Luke Harris <lkhar@amazon.com>
jsamuel1
pushed a commit
to jsamuel1/sdk-python
that referenced
this pull request
Jul 9, 2025
* Preserve deeply nested schemas * Refactor schema tests to assert entire structure --------- Authored-by: Luke Harris <lkhar@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issues
#124
Type of Change
Testing
hatch fmt --linterhatch fmt --formatterhatch test --allstrands-agentsimplementationChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.