8000 chore: updated scope name, enable setting up meter by poshinchen · Pull Request #331 · strands-agents/sdk-python · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore: updated scope name, enable setting up meter #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 3, 2025
Merged

chore: updated scope name, enable setting up meter #331

merged 1 commit into from
Jul 3, 2025

Conversation

poshinchen
Copy link
Contributor
@poshinchen poshinchen commented Jul 1, 2025 •
edited
Loading

Description

  • Disallow users to setup scope name, which ends up service_name not required.
    • scope name will become strands.telemetry.tracer which is valid
  • Enable users to set up meter
    • In python, there's no way to add metrics_exporters after the meter_provider is created. Users would either setup the meter by themselves, or call setup_meter with choices of console/otlp metrics exporters.

Documentation PR

link

Type of Change

Other (please describe):

  • Updates

Testing

How have you tested the change? Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli

  • I ran hatch run prepare

Checklist

  • I have read the CONTRIBUTING document
  • I have added any necessary tests that prove my fix is effective or my feature works
  • I have updated the documentation accordingly
  • I have added an appropriate example to the documentation to outline the feature, or no new docs are needed
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@poshinchen poshinchen requested a review from a team July 1, 2025 21:08
@poshinchen poshinchen marked this pull request as ready for review July 1, 2025 21:08
@poshinchen poshinchen force-pushed the chore/update-metrics-exporters-and-scope-name branch from a3339f3 to 961092e Compare July 2, 2025 19:55
mehtarac
mehtarac reviewed Jul 3, 2025
View reviewed changes
@poshinchen poshinchen requested review from mehtarac and a team July 3, 2025 13:30
@poshinchen poshinchen mentioned this pull request Jul 3, 2025
Merged
6 tasks
@poshinchen poshinchen merged commit 1215b88 into strands-agents:main Jul 3, 2025
22 of 32 checks passed
jsamuel1 pushed a commit to jsamuel1/sdk-python that referenced this pull request Jul 9, 2025
@poshinchen @jsamuel1
chore: updated scope name, enable setting up meter (strands-agents#331)
20cee8b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jer96 jer96 jer96 approved these changes

@mehtarac mehtarac mehtarac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@poshinchen @jer96 @mehtarac
0