8000 models - ollama - async by pgrayy · Pull Request #373 · strands-agents/sdk-python · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

models - ollama - async #373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 8, 2025
Merged

models - ollama - async #373

merged 1 commit into from
Jul 8, 2025
+76 −30

Conversation

pgrayy
Copy link
Member
@pgrayy pgrayy commented Jul 8, 2025

Description

Use the ollama.AsyncClient.

Related Issues

#83

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • Other (please describe):

Testing

How have you tested the change? Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli

  • I ran hatch run prepare
  • Wrote new integ tests.
  • Ran the following test script:
model = OllamaModel(host="http://localhost:11434", model_id="mistral-nemo")
agent = Agent(model=model, callback_handler=None)

prompt = "What is 2+2? Think through the steps."


async def func_a():
    result = await agent.invoke_async(prompt)
    print(f"FUNC_A: {result.message}")


async def func_b():
    result = await agent.invoke_async(prompt)
    print(f"FUNC_B: {result.message}")


async def func_c():
    result = await agent.invoke_async(prompt)
    print(f"FUNC_C: {result.message}")


async def func_d():
    result = await agent.invoke_async(prompt)
    print(f"FUNC_D: {result.message}")


async def main():
    await asyncio.gather(func_a(), func_b(), func_c(), func_d())


asyncio.run(main())

Using the sync Ollama Python client, every function ran sequentially and the total run time averaged 1m 30s. Using the Async Python client, every function ran concurrently and the total run time averaged 40s.

Checklist

  • I have read the CONTRIBUTING document
  • I have added any necessary tests that prove my fix is effective or my feature works
  • I have updated the documentation accordingly
  • I have added an appropriate example to the documentation to outline the feature, or no new docs are needed
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@pgrayy pgrayy temporarily deployed to auto-approve July 8, 2025 00:34 — with GitHub Actions Inactive
@pgrayy pgrayy mentioned this pull request Jul 8, 2025
Open
@pgrayy pgrayy marked this pull request as ready for review July 8, 2025 00:38
@pgrayy pgrayy merged commit 93f2eb6 into strands-agents:main Jul 8, 2025
18 of 22 checks passed
jsamuel1 pushed a commit to jsamuel1/sdk-python that referenced this pull request Jul 9, 2025
@pgrayy @jsamuel1
models - ollama - async (strands-agents#373)
f2cb03c
malte-aws pushed a commit to malte-aws/sdk-python that referenced this pull request Jul 10, 2025
@pgrayy
models - ollama - async (strands-agents#373)
fb40573
@pgrayy pgrayy deleted the async-ollma branch July 14, 2025 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zastrowm zastrowm zastrowm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pgrayy @zastrowm
0