8000 Use go-cmp.Equal instead of reflect.DeepEqual by posener · Pull Request #579 · stretchr/testify · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Use go-cmp.Equal instead of reflect.DeepEqual #579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use go-cmp.Equal instead of reflect.DeepEqual #579

wants to merge 1 commit into from

Conversation

posener
8000
Copy link
Contributor
@posener posener commented Mar 21, 2018

Closes #535

This works with https://github.com/posener/go-cmp/tree/detect-cycles2 branch of go-cmp which is in PR here: google/go-cmp#79

  • Will give us more control on comparing objects.
  • Notice the differences in the diffs, if they are acceptable.

@ernesto-jimenez
Copy link
Member
ernesto-jimenez commented Jun 9, 2018 •
edited
Loading

@posener 🙌 for the work on go-cmp!

It seems you went with a new PR. As soon as that gets merged, I would be keen to rebase this and get it merged.

@kishaningithub
Copy link
kishaningithub commented Jan 1, 2020 •
edited
Loading

@ernesto-jimenez The new PR got merged! Waiting for this to be merged and released

@boyan-soubachov boyan-soubachov added this to the v2.0.0 milestone Jul 17, 2020
@dolmen dolmen added must-rebase pkg-assert Change related to package testify/assert labels Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OscarHanzely OscarHanzely OscarHanzely approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Breaking Change must-rebase pkg-assert Change related to package testify/assert
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.

Use go-cmp instead of reflect.DeepEqual
6 participants
@posener @ernesto-jimenez @kishaningithub @OscarHanzely @dolmen @boyan-soubachov
0