8000 SDK-1129 Integrate reCAPTCHA by jhaven-stytch · Pull Request #90 · stytchauth/stytch-android · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

SDK-1129 Integrate reCAPTCHA #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Aug 30, 2023
Merged

SDK-1129 Integrate reCAPTCHA #90

merged 7 commits into from
Aug 30, 2023

Conversation

jhaven-stytch
Copy link
Contributor

Linear Ticket: SDK-1129

Changes:

  1. Adds the captcha flow to the DFP interceptor
  2. Removes shortcircuit now that we're getting the DFP settings from bootstrap data

Notes:

  • Our plan to move API configuration after the bootstrap call wasn't workable, because the API needs to be configured before making the bootstrap call (obviously!) So now configuration and DFP configuration are split into two methods, and the second one creates a new APIService (if applicable) that can be conditionally used (otherwise it falls back to the non-DFP APIService)

Checklist:

  • I have verified that this change works in the relevant demo app, or N/A
  • I have added or updated any tests relevant to this change, or N/A
  • I have updated any relevant README files for this change, or N/A

@jhaven-stytch jhaven-stytch requested a review from a team as a code owner August 25, 2023 20:39
@jhaven-stytch jhaven-stytch requested review from susie-stytch and removed request for a team August 25, 2023 20:39
@linear
Copy link
linear bot commented Aug 25, 2023

SDK-1129 [Android] Integrate Google reCAPTCHA

@jhaven-stytch jhaven-stytch merged commit b6f9802 into feature/DFP Aug 30, 2023
@jhaven-stytch jhaven-stytch deleted the susie/dfp-recaptcha branch August 30, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susie-stytch susie-stytch susie-stytch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jhaven-stytch @susie-stytch
0