8000 DFP: Unit tests by jhaven-stytch · Pull Request #91 · stytchauth/stytch-android · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

DFP: Unit tests #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 11, 2023
Merged

DFP: Unit tests #91

merged 4 commits into from
Sep 11, 2023

Conversation

jhaven-stytch
Copy link
Contributor
@jhaven-stytch jhaven-stytch commented Sep 8, 2023 •
edited
Loading

Linear Ticket: SDK-1130

Changes:

  1. Adds unit tests for DFP/Captcha request modifications
  2. Updates DeviceInfo to always return Android as the platform, instead of the codename (IDK why it was like this to begin with?)
  3. Fixes some tests that were broken in earlier DFP work (oops)

Notes:

  • This does not have tests for the DFP or Captcha provider themselves, since it relies on Android stuff and would need to be run as instrumented tests, of which we don't have any yet

Checklist:

  • I have verified that this change works in the relevant demo app, or N/A
  • I have added or updated any tests relevant to this change, or N/A
  • I have updated any relevant README files for this change, or N/A

@jhaven-stytch jhaven-stytch requested a review from a team as a code owner September 8, 2023 18:41
@jhaven-stytch jhaven-stytch requested review from susie-stytch and removed request for a team September 8, 2023 18:41
@linear
Copy link
linear bot commented Sep 8, 2023

SDK-1130 [Android] Unit Testing

susie-stytch
susie-stytch approved these changes Sep 11, 2023
View reviewed changes
Copy link
Contributor
@susie-stytch susie-stytch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jhaven-stytch jhaven-stytch merged commit 9d0ad25 into feature/DFP Sep 11, 2023
@jhaven-stytch jhaven-stytch deleted the jordan/SDK-1130-dfp-unit-tests branch September 11, 2023 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susie-stytch susie-stytch susie-stytch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jhaven-stytch @susie-stytch
0