8000 SDK-1562 R8 minification bug fix by jhaven-stytch · Pull Request #143 · stytchauth/stytch-android · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

SDK-1562 R8 minification bug fix #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 3, 2024
Merged

SDK-1562 R8 minification bug fix #143

merged 3 commits into from
Apr 3, 2024

Conversation

jhaven-stytch
Copy link
Contributor

Since the upgrade to AGP 8, R8 fullMode is enabled, which was stripping out some class definitions when minification is enabled.

Linear Ticket: SDK-1562

Changes:

  1. Bump retrofit and moshi versions to incorporate new proguard rules
  2. Annotate our requests/responses with @keep to prevent them from being stripped (there's probably a less-verbose/manual way to do this in our proguard files, but I spent 2 hours trying to figure it out with no success :( )
  3. Force minify in workbench apps for testing purposes
  4. Bump version

Notes:

  • I also published this version to my local maven repo and tested in an "external" app and verified that its working there

Checklist:

  • I have verified that this change works in the relevant demo app, or N/A
  • I have added or updated any tests relevant to this change, or N/A
  • I have updated any relevant README files for this change, or N/A

@jhaven-stytch
Bump retrofit and moshi versions to incorporate new proguard rules; a…
c355b90 
…nnotate our requests/responses with Keep to prevent them from being stripped; force minify in workbench apps for testing purposes; bump version
@jhaven-stytch
Add missing imports
2a4244d
@jhaven-stytch jhaven-stytch requested a review from a team as a code owner April 3, 2024 16:02
alex-stytch
alex-stytch approved these changes Apr 3, 2024
View reviewed changes
Copy link
@alex-stytch alex-stytch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know why the UI tests are failing?

sdk/proguard-rules.pro Outdated
@@ -28,3 +28,4 @@
-keep class androidx.credentials.playservices.** {
*;
}
-dontwarn java.lang.invoke.StringConcatFactory
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should there be a new line?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added

@jhaven-stytch
Copy link
Contributor Author

Do you know why the UI tests are failing?

They appear to be a little flaky in the AVD. I'm seeing random low-level errors like E0403 18:34:28.985345 f47a000 FrameBuffer.cpp:3790] Failed to find ColorBuffer:333, which may be contributing? Each time they fail, it's a different test, so I know it's not a code issue/actually failing test

@jhaven-stytch
Copy link
Contributor Author

Tests passed after clearing out the old caches.

@jhaven-stytch jhaven-stytch merged commit 275a7b6 into main Apr 3, 2024
@jhaven-stytch jhaven-stytch deleted the jordan/SDK-1562-minification-bug branch April 3, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alex-stytch alex-stytch alex-stytch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jhaven-stytch @alex-stytch
0