Attempt to address reported NPE on startup #236

jhaven-stytch · 2024-12-11T16:50:53Z

Linear Ticket: SDK-2311

Changes:

Moves the declaration of the flows to the top of the file, on the off-chance that somehow a value is being set (and trying to emit) before the flow has been created? Since Kotlin classes are created top-to-bottom, the "source" properties were being created before the flows. I'm unsure how the source property setters would be called before the flows were created, though.
Initializes the flows with a null value and then emits the desired value in the new-at-the-bottom init method? This goes along with the above. If I move the property initializers above the "source" properties, I don't want the source property initialization to happen before the flows are created.
Replace the emit calls with tryEmit, which removes the need for launching in a coroutine. Both methods are thread-safe, but maybe that gets out-of-whack when the emissions were launched in the application-level scope (ie: trying to call a method from Thread 2 on a property created on Thread 1)? We don't need the suspending fallback of emit because we're the only ones observing these flows AND we're guaranteed to not be listening to them until AFTER the session storages have been initialized due to the lazy delegation in the clients.

I have been unable to reproduce the reported crash, so this is kind of a blind guess as to what could be going on
Consider this a WIP for now. I'm waiting to hear back from the customer on if there are reliable repro steps, and will do some more thinking on these changes, but wanted to get something up in the interim.

…fining and emitting initial values

jhaven-stytch · 2024-12-11T16:52:24Z

jhaven-stytch added 3 commits December 11, 2024 10:53

Remove coroutines from stateflow emissions; rearrange the order of de…

7c29e84

…fining and emitting initial values

Version bump

defd83b

Update tests

f56121e

jhaven-stytch requested a review from a team as a code owner December 11, 2024 16:50

jhaven-stytch requested a review from nidal-stytch December 11, 2024 16:50

nidal-stytch approved these changes Dec 11, 2024

View reviewed changes

jhaven-stytch merged commit 5e5b93e into main Dec 11, 2024
4 checks passed

jhaven-stytch deleted the jordan/npe-on-startup branch December 11, 2024 20:15