8000 SDK-2666 Minor B2B UI Fixes by jhaven-stytch · Pull Request #294 · stytchauth/stytch-android · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

SDK-2666 Minor B2B UI Fixes #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 30, 2025
Merged

SDK-2666 Minor B2B UI Fixes #294

merged 3 commits into from
Apr 30, 2025

Conversation

jhaven-stytch
Copy link
Contributor

Linear Ticket: SDK-2666

Changes:

  1. Fix overflowing long organization names in discovery screen and ensure the logo is scaled to fill
  2. Noticed some VM recreation and ensured VMs are only created once. As a caveat of that, there were some places we were relying on the initialization behavior that we now need to explicitly call on screen load (NB: this means that these inits were running multiple times previously, which could potentially cause issues with triggering multiple TOTP or SMS events)

Notes:

Checklist:

  • I have verified that this change works in the relevant demo app, or N/A
  • I have added or updated any tests relevant to this change, or N/A
  • I have updated any relevant README files for this change, or N/A

@jhaven-stytch jhaven-stytch requested a review from a team as a code owner April 30, 2025 19:52
@jhaven-stytch jhaven-stytch requested review from jbolduc-stytch and nidal-stytch and removed request for jbolduc-stytch April 30, 2025 19:52
@jhaven-stytch
Copy link
Contributor Author

Code Coverage

Overall Project 72.43% 🍏
File Coverage
StytchB2BAuthenticationApp.kt 0% 🍏

@jhaven-stytch jhaven-stytch merged commit 8c240ef into main Apr 30, 2025
4 checks passed
@jhaven-stytch jhaven-stytch deleted the jordan/B2B-UI-Fixes branch April 30, 2025 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nidal-stytch nidal-stytch nidal-stytch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jhaven-stytch @nidal-stytch
0