8000 Redo Consumer Workbench App (and deprecate standalone UI app) by jhaven-stytch · Pull Request #304 · stytchauth/stytch-android · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Redo Consumer Workbench App (and deprecate standalone UI app) #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 15, 2025
Merged

Redo Consumer Workbench App (and deprecate standalone UI app) #304

merged 7 commits into from
May 15, 2025

Conversation

jhaven-stytch
Copy link
Contributor
@jhaven-stytch jhaven-stytch commented May 14, 2025 •
edited
Loading

Linear Ticket: SDK-2662, SDK-2664

Changes:

  1. Removes the standalone B2C UI workbench app in favor of merging it into the regular workbench app (it did so little on it's own, and each additional app adds time to builds/code scans)
  2. Redo the consumer workbench app to house both headless and UI implementations (like we do for B2B), as well as clean up the actual UX so you can see what you're doing in there. It's gotten really unwieldy with all of the various methods that were added since it's inception. Also makes some of the screens smarter (like biometrics; the buttons enable/disable based on if their actions are possible). Otherwise, the functionality is basically the same.
  3. Remove the necessity of the local.properties, and instead rely on string resources for all config (essentially standardizing on what we do for public tokens). Part of this means, because of how AAPT works and not wanting to check in secrets, that users must define these two new resources when using the workbench apps, which I feel is acceptable, since they are internal/test things. It also means I had to scale down the purview of the CodeQL tests; now it only tests/analyzes the SDK instead of all of the demo apps too. Again, I think that's fine. Makes it much faster to boot.
  4. Update README

Notes:

  • A similar PR will be coming to do the same for B2B workbench, which is somehow even worse regarding UX

Checklist:

  • I have verified that this change works in the relevant demo app, or N/A
  • I have added or updated any tests relevant to this change, or N/A
  • I have updated any relevant README files for this change, or N/A

@jhaven-stytch
Copy link
Contributor Author

Code Coverage

Overall Project 72.46% 🍏

There is no coverage information present for the Files changed

@jhaven-stytch jhaven-stytch marked this pull request as ready for review May 14, 2025 20:44
@jhaven-stytch jhaven-stytch requested a review from a team as a code owner May 14, 2025 20:44
@jhaven-stytch jhaven-stytch merged commit 62d9a45 into main May 15, 2025
4 checks passed
@jhaven-stytch jhaven-stytch deleted the jordan/redo-workbench-apps branch May 15, 2025 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nidal-stytch nidal-stytch nidal-stytch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jhaven-stytc 322F h @nidal-stytch
0