8000 SDK-2719 Add configuration option to choose between webview and native DFP implementations by jhaven-stytch · Pull Request #319 · stytchauth/stytch-android · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

SDK-2719 Add configuration option to choose between webview and native DFP implementations #319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 5, 2025
Merged

SDK-2719 Add configuration option to choose between webview and native DFP implementations #319

merged 2 commits into from
Jun 5, 2025

Conversation

jhaven-stytch
Copy link
Contributor

Linear Ticket: SDK-2719

Changes:

  1. Adds a new option to StytchClientOptions to switch between native and webview DFP implementations
  2. Updates DFPProvider to instantiate and use the correct DFP implementation based on configuration

Notes:

  • To use webview DFP, one would need to pass the following to StytchClient.configure(): StytchClientOptions(dfpType = DFPType.Webview)

Checklist:

  • I have verified that this change works in the relevant demo app, or N/A
  • I have added or updated any tests relevant to this change, or N/A
  • I have updated any relevant README files for this change, or N/A

@jhaven-stytch jhaven-stytch requested a review from a team as a code owner June 5, 2025 18:37
@jhaven-stytch
Copy link
Contributor Author

Code Coverage

Overall Project 72.08% -0.71% 🍏
Files changed 23.35% ❌

File Coverage
DFPType.kt 90.48% -4.76% 🍏
ConfigurationManager.kt 88.02% -1.35% ❌
DFPProvider.kt 23.53% -68.98% ❌
WebviewActivityProvider.kt 0% -55% ❌

pverheecke-stytch
pverheecke-stytch approved these changes Jun 5, 2025
View reviewed changes
Copy link
@pverheecke-stytch pverheecke-stytch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very little context here of course, but again, seems reasonable!

@jhaven-stytch jhaven-stytch merged commit 0931064 into main Jun 5, 2025
4 of 5 checks passed
@jhaven-stytch jhaven-stytch deleted the jordan/SDK-2719-configurable-dfp branch June 5, 2025 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pverheecke-stytch pverheecke-stytch pverheecke-stytch approved these changes

@nstam-stytch nstam-stytch Awaiting requested review from nstam-stytch nstam-stytch is a code owner automatically assigned from stytchauth/mobile-sdks

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jhaven-stytch @pverheecke-stytch
0