fix(sp1up): correct openssl warning message in install script #2184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm thank you |
nhtyy
approved these changes
Mar 28, 2025
nhtyy
pushed a commit
that referenced
this pull request
Apr 1, 2025
ultraspicy
pushed a commit
to ultraspicy/sp1
that referenced
this pull request
Jun 1, 2025
ultraspicy
pushed a commit
to ultraspicy/sp1
that referenced
this pull request
Jun 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
While trying to run my sp1up install script on my Mac, I was sort of losing it because I didn't have OpenSSL. The script performs two separate checks for required libraries under macOS: the first one is right to give a warning about missing libusb, but the second one (for OpenSSL) is wrong in copying the libusb warning.
Solution
This pull request corrects the sp1up install script so the OpenSSL check will print the correct warning message. The message has been revised to:
This fix should prevent mac users from being confused and spare others the frustration I had to endure.
PR Checklist