8000 fix(patches): 4.1.0 secp256k1 patch by nhtyy · Pull Request #2198 · succinctlabs/sp1 · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(patches): 4.1.0 secp256k1 patch #2198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 2, 2025
Merged

fix(patches): 4.1.0 secp256k1 patch #2198

merged 3 commits into from
Apr 2, 2025

Conversation

nhtyy
Copy link
Collaborator
@nhtyy nhtyy commented Apr 1, 2025

The patch was never updated to use the new 4.1.0 k256 patch

@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Apr 1, 2025 •
edited
Loading
Test Old New Diff
curve25519_dalek_test_zero_mul 197293 197293 0.0000 %
curve25519_dalek_test_decompressed_noncanonical 9192 9192 0.0000 %
sha_test_sha2_expected_digest_lte_100_times 3767137 3768343 0.0320 %
secp256k1_program_test_recover_rand_lte_100 6574922 6589915 0.2280 %
p256_test_recover_pubkey_infinity 135253 135253 0.0000 %
bn_test_bn_test_fr_inverse_100 799750 799750 0.0000 %
k256_test_schnorr_verify 7022137 7022886 0.0107 %
rust_crypto_rsa_test_pkcs_verify_100 102171953 102635496 0.4537 %
bls12_381_tests_test_bls_add_100 15779134 15779134 0.0000 %
k256_test_verify_rand_lte_100 24660798 24652358 -0.0342 %
curve25519_dalek_ 8000 test_ed25519_verify 32285991 32288638 0.0082 %
rustcrypto_bigint_test_bigint_mul_add_residue 2237560 2237560 0.0000 %
secp256k1_program_test_verify_rand_lte_100 43413404 43376006 -0.0861 %
bn_test_bn_test_fq_inverse_100 777050 777050 0.0000 %
p256_test_verify_rand_lte_100 24937641 25013692 0.3050 %
curve25519_dalek_test_add_then_multiply 7231871 7260715 0.3988 %
curve25519_dalek_ng_test_decompressed_noncanonical 204652 204652 0.0000 %
k256_test_recover_rand_lte_100 5786029 5762008 -0.4152 %
p256_test_recover_rand_lte_100 6981921 6990529 0.1233 %
bn_test_bn_test_fq_sqrt_100 796650 796650 0.0000 %
curve25519_dalek_ng_test_zero_msm 216881 216881 0.0000 %
sha_test_sha3_expected_digest_lte_100_times 1793156 1793484 0.0183 %
bls12_381_tests_test_inverse_fp_100 1642511 1642511 0.0000 %
p256_test_recover_high_hash_high_recid 3149937 3421978 8.6364 %
bn_test_bn_test_g1_add_100 839695 839709 0.0017 %
bls12_381_tests_test_bls_double_100 9782437 9782437 0.0000 %
curve25519_dalek_test_decompressed_expected_value 16001701 15695217 -1.9153 %
k256_test_recover_high_hash_high_recid 2841056 2678056 -5.7373 %
curve25519_dalek_ng_test_zero_mul 197263 197263 0.0000 %
k256_test_recover_pubkey_infinity 129852 129852 0.0000 %
bls12_381_tests_test_sqrt_fp_100 1056097 1002275 -5.0963 %
bls12_381_tests_test_inverse_fp2_100 3108161 3108161 0.0000 %
curve25519_dalek_ng_test_add_then_multiply 7255400 7103686 -2.0910 %
curve25519_dalek_test_zero_msm 213225 213225 0.0000 %
bls12_381_tests_test_sqrt_fp2_100 1959559 1757680 -10.3023 %
keccack_test_expected_digest_lte_100 2029258 2030007 0.0369 %
bn_test_bn_test_g1_double_100 643598 643598 0.0000 %
rustcrypto_bigint_test_bigint_mul_mod_special 2336198 2336198 0.0000 %

@nhtyy nhtyy force-pushed the n/secp256k1-4.1.0 branch from 29b8cba to fc6c88a Compare April 2, 2025 02:21
@nhtyy nhtyy merged commit 81757da into dev Apr 2, 2025
1 check passed
@nhtyy nhtyy deleted the n/secp256k1-4.1.0 branch April 2, 2025 02:21
ultraspicy pushed a commit to ultraspicy/sp1 that referenced this pull request Jun 1, 2025
@nhtyy
fix(patches): 4.1.0 secp256k1 patch (succinctlabs#2198)
61a0f1e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nhtyy
0