8000 chore: check syscalls in secp256k1_verify test by leruaa · Pull Request #2203 · succinctlabs/sp1 · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore: check syscalls in secp256k1_verify test #2203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 2, 2025
Merged

chore: check syscalls in secp256k1_verify test #2203

merged 1 commit into from
Apr 2, 2025

Conversation

leruaa
Copy link
Contributor
@leruaa leruaa commented Apr 2, 2025 •
edited
Loading

Motivation

Check that the SECP256K1_DOUBLE and SECP256K1_ADD syscalls are actually called.

@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Apr 2, 2025
Test Old New Diff
bn_test_bn_test_fr_inverse_100 799750 799750 0.0000 %
p256_test_recover_rand_lte_100 6988386 6984332 -0.0580 %
curve25519_dalek_test_zero_msm 213225 213225 0.0000 %
k256_test_schnorr_verify 7016305 7014237 -0.0295 %
bls12_381_tests_test_inverse_fp_100 1642511 1642511 0.0000 %
p256_test_recover_pubkey_infinity 135253 135253 0.0000 %
curve25519_dalek_ng_test_add_then_multiply 7823513 7285786 -6.8732 %
bn_test_bn_test_fq_sqrt_100 796650 796650 0.0000 %
rustcrypto_bigint_test_bigint_mul_add_residue 2237560 2237560 0.0000 %
bls12_381_tests_test_bls_add_100 15779134 15779134 0.0000 %
curve25519_dalek_ng_test_zero_mul 197263 197263 0.0000 %
k256_test_recover_pubkey_infinity 129852 129852 0.0000 %
k256_test_recover_rand_lte_100 5755841 5769090 0.2302 %
p256_test_verify_rand_lte_100 25042722 25012928 -0.1190 %
secp256k1_program_test_recover_rand_lte_100 6584981 6589019 0.0613 %
sha_test_sha2_expected_digest_lte_100_times 3766321 3765308 -0.0269 %
bls12_381_tests_test_bls_double_100 9782437 9782437 0.0000 %
bn_test_bn_test_fq_inverse_100 777050 777050 0.0000 %
k256_test_verify_rand_lte_100 24591442 24670264 0.3205 %
bn_test_bn_test_g1_double_100 643598 643598 0.0000 %
curve25519_dalek_ng_test_decompressed_noncanonical 204652 204652 0.0000 %
p256_test_recover_high_hash_high_recid 2979065 3643554 22.3053 %
rustcrypto_bigint_test_bigint_mul_mod_special 2336198 2336198 0.0000 %
bls12_381_tests_test_inverse_fp2_100 3108161 3108161 0.0000 %
curve25519_dalek_test_zero_mul 197293 197293 0.0000 %
curve25519_dalek_test_decompressed_noncanonical 9192 9192 0.0000 %
curve25519_dalek_test_add_then_multiply 6268477 7804626 24.5059 %
bls12_381_tests_test_sqrt_fp2_100 1959415 1986353 1.3748 %
bls12_381_tests_test_sqrt_fp_100 1083065 1002379 -7.4498 %
curve25519_dalek_test_decompressed_expected_value 15850542 16157026 1.9336 %
curve25519_dalek_ng_test_zero_msm 216881 216881 0.0000 %
keccack_test_expected_digest_lte_100 2028418 2034907 0.3199 %
bn_test_bn_test_g1_add_100 839695 839695 0.0000 %
curve25519_dalek_test_ed25519_verify 32288984 32285681 -0.0102 %
sha_test_sha3_expected_digest_lte_100_times 1793282 1793473 0.0107 %
rust_crypto_rsa_test_pkcs_verify_100 102451950 102061046 -0.3815 %
secp256k1_program_test_verify_rand_lte_100 43370076 43422312 0.1204 %
k256_test_recover_high_hash_high_recid 2872562 2782500 -3.1352 %

ratankaliani
ratankaliani approved these changes Apr 2, 2025
View reviewed changes
Copy link
Contributor
@ratankaliani ratankaliani left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Given the description is empty, can you remove it from the PR?

@leruaa leruaa merged commit 0608fb2 into dev Apr 2, 2025
3 checks passed
@leruaa leruaa deleted the aurelien/check-syscalls-in-secp256k1-verify branch April 2, 2025 19:54
ultraspicy pushed a commit to ultraspicy/sp1 that referenced this pull request Jun 1, 2025
@leruaa
chore: check syscalls in secp256k1_verify test (succinctlabs#2203)
8f05854
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ratankaliani ratankaliani ratankaliani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leruaa @ratankaliani
0