Move document manager components to this repository #3981
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7f3ec90 to
fd1a8ac
Compare
fd1a8ac to
69b5c66
Compare
8fa22fa to
1f0fb1f
Compare
|
ping @danrot |
1f0fb1f to
9b8baeb
Compare
composer.json
Outdated
| "symfony-cmf/routing-bundle": "^2.0", | ||
| "symfony-cmf/slugifier-api": "~1.0", |
There was a problem hiding this comment.
here both can be accepted ^1.0 || ^2.0
6dda5b6 to
f2aa020
Compare
f2aa020 to
3b72c16
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Move document manager components to this repository.
Why?
For better maintenance and compatibility.
See 9b8baeb for changes
TODO
AutoNameSubscriberTest::testAlreadyHasNode: This test did not perform any assertions: Don't know if there is a bug or the test is just really strange as most functions are not called when I add shouldBeCalled.