Interpret .php as html request format to show correct error page #4013
Conversation
77bd8f8 to
26dc55a
Compare
| @@ -114,6 +114,10 @@ private function getResourceLocatorFromRequest(PortalInformation $portalInformat | |||
| strlen($portalInformation->getUrl()) | |||
| ); | |||
|
|
|||
| if ('php' === $formatResult) { | |||
There was a problem hiding this comment.
Shouldn't we fallback to html in general? We have exactly the same problem when people are typing something like /index.asdf.
There was a problem hiding this comment.
@danrot
@wachterjohannes or @chirimoya said there where usecases where the ending was something like .newsletter so this would make it a little difficult without a bc break doing that.
There was a problem hiding this comment.
@danrot maybe we should just fix something in the exception controller instead of overwritting the request format behaviour? /cc @sulu/core-team
There was a problem hiding this comment.
@alexander-schranz Your latest suggestion what we have just discussed with @chirimoya :-) I think we should do it this way. This keeps the old behaviour and fixes the messed up error message for unknown formats.
26dc55a to
440e7ee
Compare
What's in this PR?
Interpret .php as html request format to show correct error page.
Why?
Else php will render the symfony standard error page.
Example Usage
/test.php