Fix sortBy in DataProviderRepositoryTrait #6619
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luca-rath
commented
May 23, 2022
| if (strpos($sortColumn, '.') === false) { | ||
| $sortColumn = 'c.' . $sortColumn; | ||
| } | ||
|
|
||
| $queryBuilder->addSelect($sortColumn); |
There was a problem hiding this comment.
addSelect() throws an error if the column doesn't contain an alias while addOrderBy() allows the column to not have an alias
There was a problem hiding this comment.
I'm sorry, this is not true 🤦 The appendSortBy() method was overridden in the project, therefore it worked
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Fix sortBy in DataProviderRepositoryTrait