8000 Include properties inside of nested blocks in search index by mgwestwerk · Pull Request #6205 · sulu/sulu · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Include properties inside of nested blocks in search index #6205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 30, 2021
Merged

Include properties inside of nested blocks in search index #6205

merged 4 commits into from
Sep 30, 2021

Conversation

mgwestwerk
Copy link
Contributor
Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Fixed tickets -
Related issues/PRs -
License MIT
Documentation PR -

What's in this PR?

This PR allows properties inside nested blocks to be used as search fields

Why?

Currently only properties that are one level deep inside a block will be indexed if marked as search field

@alexander-schranz alexander-schranz added the Feature New functionality not yet included in Sulu label Sep 15, 2021
@niklasnatter niklasnatter changed the base branch from 2.x to 2.2 September 30, 2021 08:45
niklasnatter
niklasnatter approved these changes Sep 30, 2021
View reviewed changes
Copy link
Contributor
@niklasnatter niklasnatter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not have a lot of experience with this part of the code. But from my perspective, the changed code looks good!

I have tested the changes on my machine and the result looks correct to me 🙂
For completion, the following picture shows a comparison between an indexed page before (left) and after (right) the changes in this PR.

Screenshot 2021-09-30 at 11 56 12

Thanks a lot for working on this!

8000
@niklasnatter niklasnatter changed the title Enable search in properties inside nested blocks Include properties inside of nested blocks in search index Sep 30, 2021
@niklasnatter niklasnatter merged commit f3ec09d into sulu:2.2 Sep 30, 2021
This was referenced Oct 5, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niklasnatter niklasnatter niklasnatter approved these changes

Assignees
No one assigned
Labels
Feature New functionality not yet included in Sulu
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mgwestwerk @niklasnatter @alexander-schranz
0