8000 Fixed `get_horizons_coord()` docstring to omit an unsupported option by ayshih · Pull Request #8190 · sunpy/sunpy · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fixed get_horizons_coord() docstring to omit an unsupported option #8190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 13, 2025
Merged

Fixed get_horizons_coord() docstring to omit an unsupported option #8190

merged 1 commit into from
May 13, 2025

Conversation

ayshih
Copy link
Member
@ayshih ayshih commented May 13, 2025

Closes #8188

Hmm, the (current) Horizons API documentation is clear that "s" is not a supported option. I don't know if "s" was ever supported in past, but certainly our docstring is now wrong.

Originally posted by @ayshih in #8188

@ayshih ayshih added coordinates Affects the coordinates submodule Minor Change PR only needs one approval to merge. < 8000 a id="label-3bc9ad" href="/sunpy/sunpy/labels/backport%206.0" data-name="backport 6.0" style="--label-r:198;--label-g:1;--label-b:166;--label-h:309;--label-s:98;--label-l:39;" data-view-component="true" class="IssueLabel hx_IssueLabel d-inline-block v-align-middle"> backport 6.0 on-merge: backport to 6.0 Documentation Affects the documentation. backport 6.1 on-merge: backport to 6.1 labels May 13, 2025
@ayshih ayshih force-pushed the horizons_step_size branch from eabd1b8 to 7c792d3 Compare May 13, 2025 15:51
@ayshih ayshih marked this pull request as ready for review May 13, 2025 15:51
@ayshih ayshih requested a review from a team as a code owner May 13, 2025 15:51
@nabobalis nabobalis merged commit 3da60a7 into sunpy:main May 13, 2025
27 of 29 checks passed
meeseeksmachine pushed a commit to meeseeksmachine/sunpy that referenced this pull request May 13, 2025
@nabobalis @meeseeksmachine
Backport PR sunpy#8190: Fixed get_horizons_coord() docstring to omi…
4bf8973 
…t an unsupported option
@meeseeksmachine meeseeksmachine mentioned this pull request May 13, 2025
Merged
meeseeksmachine pushed a commit to meeseeksmachine/sunpy that referenced this pull request May 13, 2025
@nabobalis @meeseeksmachine
Backport PR sunpy#8190: Fixed get_horizons_coord() docstring to omi…
b2c8c08 
…t an unsupported option
@meeseeksmachine meeseeksmachine mentioned this pull request May 13, 2025
Merged
@ayshih ayshih deleted the horizons_step_size branch May 17, 2025 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nabobalis nabobalis nabobalis approved these changes

Assignees
No one assigned
Labels
backport 6.0 on-merge: backport to 6.0 backport 6.1 on-merge: backport to 6.1 coordinates Affects the coordinates submodule Documentation Affects the documentation. Minor Change PR only needs one approval to merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

get_horizons_coord error with step='60s'
2 participants
@ayshih @nabobalis
0