PUNCHMap #8133
PUNCHMap #8133
Conversation
There was a problem hiding this comment.
Sorry this has taken so long to review! I've attached a few suggested changes. Looking at the sample header provided, I don't think many of these properties are needed with the exception of unit which I think needs some additional logic.
This will also need a changelog.
|
pre-commit.ci autofix |
|
I've made some changes locally that I'll push up by the end of the day - but it should hopefully resolves the units issue, and the updated header. Thank you all for your patience with this! |
|
hey @lowderchris this Friday is our feature freeze for 7.0, so we would like to see this PR merged by then if you have some time to respond to the rest of the comments this week? Thanks! |
Co-authored-by: Nabil Freij <nabil.freij@gmail.com>
Co-authored-by: Nabil Freij <nabil.freij@gmail.com>
|
@Cadair absolutely - again sorry for the delay on this! Did those changes address everything? I'm happy to do any last fixes today as well if that would make things easier. |
|
@lowderchris Thanks! We normally write up a little what's new entry for things like this as we are preparing a release. Do you have an example file to use / plot you've made that would be good to include to show this off? |
Absolutely - would something like the attached plot work? I used this new code to load some PUNCH / WFI data to plot as a map. |
|
Looks great to me! Lets use it. |
|
Thanks very much for your contribution @lowderchris 🥳 |
PR Description
After some discussion with SunPy folks, we've worked on creating a PUNCHMap class to handle two-dimensional PUNCH data. Closes #8132 . This pull request:
Definitely let us know of any changes we can make - thanks!