WIP: Fixing window configuration issues #119
Conversation
|
@vspinu maybe try this branch out and let me know how it goes. Not perfect yet.... |
|
So I 8000 think what is going on is that Sunrise is not aware that it was opened prior, and keeps creating new windows. That is why my hack kinda "works". The real fix is for Sunrise to be able to find its old panes if they still exist. |
|
Pushed a few commits that removed some hacks and got things to be much more stable (changing pane layout now works again!) Additionally #118 should be fixed now too. Panes are still being remade whenever the pane layout switches, however, so there is still some work left. |
| (or (sunrise-quit) (sunrise-show))) | ||
| (or (sunrise-quit) (sunrise-setup t))) | ||
|
|
||
| (defun sunrise-setup-windows () |
There was a problem hiding this comment.
This function used to exist before the refactor and parts of the code still call it... I tried to re-add it back in as a way to repaint the panes. I suspect there is a better way to repaint panes instead of essentially restarting Sunrise, but that's the hack I did for now.
I know this isn't a clean PR yet and has some hacks, but I just wanted to get it out there. These changes have gotten Sunrise Commander to exhibit most of its old behavior in terms of restoring panes. Some of the bugs I am trying to fix are documented in #115
Basically, on Emacs 28, Sunrise Commander has the current bugs:
(sunrise-toggle)window configurationThis PR mostly fixes these things.
Some things are wrong though... like, we should be opening the active pane directory based on the currently active buffer, I think. And some of my work in sunrise-quit is redundant. And I don't think I'm focusing on the right buffer for the "view panel".