8000 Fix metal3 chart small issues by diconico07 · Pull Request #223 · suse-edge/charts · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix metal3 chart small issues #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 4, 2025
Merged

Fix metal3 chart small issues #223

merged 2 commits into from
Jun 4, 2025

Conversation

diconico07
Copy link
Collaborator

Fix several small issues with the metal3 chart:

  • scope issue leading to error when defining extra annotations for Ironic
  • version mismatch for the Ironic image tag in the media subchart

diconico07 added 2 commits June 4, 2025 11:15
@diconico07
Fix metal3 chart
f308ec7 
See https://src.opensuse.org/suse-edge/Factory/pulls/172 for details

Signed-off-by: Nicolas Belouin <nicolas.belouin@suse.com>
@diconico07
make charts/html
36863a8 
Signed-off-by: Nicolas Belouin <nicolas.belouin@suse.com>
@diconico07 diconico07 requested review from hardys and mchiappero June 4, 2025 09:28
@diconico07
Copy link
Collaborator Author

This will fix #222

mchiappero
mchiappero approved these changes Jun 4, 2025
View reviewed changes
Copy link
Contributor
@mchiappero mchiappero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@diconico07 diconico07 merged commit 9153fbf into suse-edge:main Jun 4, 2025
2 checks passed
@diconico07 diconico07 deleted the fix-metal3 branch June 4, 2025 12:54
@hardys hardys mentioned this pull request Jun 20, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hardys hardys hardys approved these changes

@mchiappero mchiappero mchiappero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@diconico07 @hardys @mchiappero
0