feat: parsing & validating the new redirect url patterns #2048
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 15561832509Details
💛 - Coveralls |
hf
approved these changes
Jun 9, 2025
| } | ||
|
|
||
| // CategorizePattern determines the type of a redirect uri and returns a RedirectPattern | ||
| func CategorizePattern(pattern string) (RedirectPattern, error) { |
There was a problem hiding this comment.
I see a few glob.Compile() calls in this function. It should be OK from a performance POV and definitely not a blocker, but maybe double-check (if you haven't already) what the library docs say about it
There was a problem hiding this comment.
Good catch! We're only calling glob.Compile() during app startup when parsing the config, not during the requests (aka compile-once, match-many). Since it's a one-time initialization cost, there's no performance concern here. The library warns against compiling repeatedly in hot paths, which we're not doing.
We're good!
cstockton
approved these changes
Jun 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements the new redirect URI validation system as specified in the technical specification. This introduces a cleaner, more maintainable approach to redirect URI validation with automatic pattern categorization.
What kind of change does this PR introduce?
Feature - New redirect URI validation system with pattern categorization
What is the current behavior?
Supabase Auth currently uses an overly permissive redirect URL system that supports dangerous wildcard patterns like
**which create security vulnerabilities The validation logic is scattered and uses complex glob patterns that are difficult to maintain and debug.What is the new behavior?
Implements Phase 1 of the redirect URI security enhancement by introducing a new categorized validation system in the
internal/redirecturipackage. This lays the foundation for migrating away from dangerous wildcard patterns to a more secure, OAuth-compliant approach.New pattern categories:
https://example.com/callback(literal matching)example.com(any HTTPS path on domain)*.preview.app(subdomain matching only)myapp://(mobile app deep links)Additional context
Merging this PR won't have any affect on the existing behaviour.
The actual parsing & validating (shadow mode) will be enabled in a future PR.