enh: prefix schema to enum migrations #2040
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for nonstandard search path migrations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for nonstandard search path migrations
What kind of change does this PR introduce?
Continuation of #1983 and fixes #1729
What is the current behavior?
The current migration script assumes the search path has been set to a custom schema.
If this step missed, the default schema for all migrations is
public. This should be fine if all tables and enums are prefixed accordingly, but currently it's not. All postgres enum is not prefixed with schema.What is the new behavior?
All postgres enum will be prefixed with the schema. This should fixes issue #1729 where the migration is broken if search path is not set properly.
This doesn't introduce a breaking change, because if
search_pathis already set all enums stay on the formersearch_path.Additional context
Haven't test. Will test soon.