10000 [Legacy Driver] Obsolete and remove batch compilation mode from the legacy driver by artemcm · Pull Request #81569 · swiftlang/swift · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[Legacy Driver] Obsolete and remove batch compilation mode from the legacy driver #81569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Legacy Driver] Obsolete and remove batch compilation mode from the legacy driver #81569

wants to merge 1 commit into from
+35 −1,526

Conversation

artemcm
Copy link
Contributor
@artemcm artemcm commented May 16, 2025

It is a maintenance burden and having the legacy driver exist in a simplified state reduces the possibility of things going wrong and hitting old bugs.

@artemcm
Copy link
Contributor Author
artemcm commented May 16, 2025

@swift-ci test

@artemcm
Copy link
Contributor Author
artemcm commented May 16, 2025

@swift-ci test

@artemcm
Copy link
Contributor Author
artemcm commented May 19, 2025

@swift-ci test Linux platform

@artemcm
Copy link
Contributor Author
artemcm commented May 20, 2025

@swift-ci test Windows platform

2 similar comments
@artemcm
Copy link
Contributor Author
artemcm commented May 22, 2025

@swift-ci test Windows platform

@artemcm
Copy link
Contributor Author
artemcm commented Jun 5, 2025

@swift-ci test Windows platform

@artemcm
[Legacy Driver] Obsolete and remove batch compilation mode from the l…
10cd7ba 
…egacy driver

It is a maintenance burden and having the legacy driver exist in a simplified state reduces the possibility of things going wrong and hitting old bugs.
@artemcm
Copy link
Contributor Author
artemcm commented Jun 6, 2025

@swift-ci test

@artemcm
Copy link
Contributor Author
artemcm commented Jun 9, 2025

@swift-ci test macOS platform

3 similar comments
@artemcm
Copy link
Contributor Author
artemcm commented Jun 10, 2025

@swift-ci test macOS platform

@artemcm
Copy link
Contributor Author
artemcm commented Jun 10, 2025

@swift-ci test macOS platform

@artemcm
Copy link
Contributor Author
artemcm commented Jun 10, 2025

@swift-ci test macOS platform

@artemcm
Copy link
Contributor Author
artemcm commented Jun 10, 2025

#82167
@swift-ci test

@artemcm
Copy link
Contributor Author
artemcm commented Jun 11, 2025

@swift-ci test macOS platform

@artemcm artemcm marked this pull request as ready for review June 12, 2025 13:09
@artemcm artemcm requested a review from tshortli as a code owner June 12, 2025 13:09
cachemeifyoucan
cachemeifyoucan reviewed Jun 12, 2025
View reviewed changes
Copy link
Contributor
@cachemeifyoucan cachemeifyoucan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still support the testing new swift-driver from lit test?

Maybe instead of removing all the tests, we should add a feature for legacy-driver and disable the batch test under legacy-driver.

@artemcm
Copy link
Contributor Author
artemcm commented Jun 12, 2025

Do we still support the testing new swift-driver from lit test?

Maybe instead of removing all the tests, we should add a feature for legacy-driver and disable the batch test under legacy-driver.

To my knowledge and a quick scan of logs/configs to sanity check, we have never actually ran these test sets with swift-driver, so I'd rather we lean more on its own test suite.

@cachemeifyoucan
Copy link
Contributor
cachemeifyoucan commented Jun 12, 2025 •
edited
Loading

I am talking about this: https://github.com/swiftlang/swift-driver/blob/8594e088e4a9dcb84496794d80d08ceb7458a093/README.md?plain=1#L86-L99

I think today, if we didn't specify use legacy only flag in lit.cfg, we will actually test new swift-driver if we run the Driver test in swift repo.

@artemcm
Copy link
Contributor Author
artemcm commented Jun 12, 2025

I am talking about this: https://github.com/swiftlang/swift-driver/blob/8594e088e4a9dcb84496794d80d08ceb7458a093/README.md?plain=1#L86-L99

I think today, if we didn't specify use legacy only flag in lit.cfg, we will actually test new swift-driver if we run the Driver test in swift repo.

I don't think we do, due to these:
https://github.com/swiftlang/swift-driver/blob/8594e088e4a9dcb84496794d80d08ceb7458a093/Tests/SwiftDriverTests/IntegrationTests.swift#L123
Which we never got around to enabling in the first place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cachemeifyoucan cachemeifyoucan cachemeifyoucan left review comments

@tshortli tshortli tshortli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@artemcm @cachemeifyoucan @tshortli
0