Make InferIsolatedConformances and StrictMemorySafety migratable features
#81703
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When migrating, provide warnings that add 'nonisolated' to nonisolated conformances that don't already have it and would end up being inferred to be isolated under the upcoming feature.
This feature is essentially self-migrating, but fit it into the migration flow by marking it as migratable, adding `-strict-memory-safety:migrate`, and introducing a test.
The name of a migratable feature might differ from the names of the diagnostic groups containing the diagnostics that are used to drive migration for that feature. Provide the set of diagnostic categories that are associated with each migratable feature as part of the supported features list.
Optional language features don't have a specific "-enable-*" flag, because they're rare and don't fit the same upcoming/experimental distinction. Add a flag_name field to provide the flag name as well.
|
@swift-ci please smoke test |
AnthonyLatsis
approved these changes
May 22, 2025
|
@swift-ci please smoke test |
xedin
reviewed
May 22, 2025
| // CHECK-NEXT: "upcoming": [ | ||
| // CHECK: { "name": "{{.*}}"{{, "migratable": true}}, "enabled_in": "{{.*}}" } | ||
| // CHECK: { "name": "InferIsolatedConformances", "migratable": true, "categories": ["IsolatedConformances"], "enabled_in": "7" }, |
There was a problem hiding this comment.
We really need to come up with a test that checks the structure here too...
There was a problem hiding this comment.
If we have Foundation around, we could mock up some Codable structs/enums and make sure it deserializes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both
InferIsolatedConformancesandStrictMemorySafetyhave an automatable migration path. Make both into migratable features. This required some extensions to the "supported features" that the compiler provides for the migration tooling:categories, which are the names of the diagnostic categories whose diagnostics should be considered part of that migration. We were assuming that the category name lined up with the feature name, which is not always the case (as withInferIsolatedConformances, whose diagnostic category is `IsolatedConformances).StrictMemorySafety.