remove unused version number in Makefile #679
Conversation
|
Hello, personally I appreciate that the current script creates an archive of the compiled code during the install step, which can be useful for regression tracking. |
Have you considered using git for this purpose? |
|
I would advocate for choosing #678 over this myself. I have to install wacky libnx versions myself and manage them without git commits, and would appreciate us keeping the dist-src target. I will probably pull request to re-add it if this is merged. |
|
An unused version number in the Makefile is a maintenance burden which doesn't need to exist. This is just cruft that was carried over from before we maintained everything via pacman. |
|
I don't care about the version number but I do care about the dist-src target. I would be fine with it using the commit hash the same way atmosphere does. |
|
(Automatically parsing the commit hash the way ams does would, I believe, completely solve the "maintenance burden" problem.) |
Git doesn't keep compiled archives which van be a pain to compile with newer versions of the toolchain. I know this is not meant to work all the time and might create all sort of issues, but it's harmless and occasionally useful. Side note. I worded my message as politely as possible and I believe in receiving the same amount of respect that was given, especially as a long-time contributor to the switch homebrew ecosystem. |
git hashes aren't available when packaging, archives are obtained from the github tag based on the version number in the PKGBUILD. |
|
Git hashes are available when typing make dist-src, I use this in atmosphere. Would it be helpful if I pull requested it myself? |
|
fwiw ams does "export ATMOSPHERE_GIT_HASH := $(shell git rev-parse --short=16 HEAD)" in makefile. |
|
Anyway, I am on an international flight which is taking off as I post this, so I'll be unavailable for the next 11 hours. I ask @fincs and @yellows8 personally in my capacity as a developer for this library and as a long-time maintainer for the switch as a homebrew ecosystem (and this library): please do not merge this as-is, since if it is merged I will have to pull request the addition of a fixed dist-src target. |
| @@ -98,14 +91,15 @@ all: lib/libnx.a lib/libnxd.a | |||
| dist-bin: all | |||
| @tar --exclude=*~ -cjf libnx-$(VERSION).tar.bz2 include lib default_icon.jpg switch_rules switch.ld switch.specs -C external/bsd include | |||
There was a problem hiding this comment.
dist-bin still references the removed VERSION.
(Presumably forgot to remove it?)
There was a problem hiding this comment.
bah, yes, missed the dist-bin target, thanks.
There was a problem hiding this comment.
2084398 is missing from master
Supercedes #678