Add is_algebraic and is_transcendental #1819
Conversation
| void bvisit(const Set &x); | ||
| void bvisit(const Relational &x); | ||
| void bvisit(const Boolean &x); | ||
| void bvisit(const Constant &x); |
There was a problem hiding this comment.
Should we be implementing things like Add, Mul, Pow?
There was a problem hiding this comment.
As far as I understand there are no general rules known for these. We'd have to create special cases for what is know.
There was a problem hiding this comment.
algebraic + algebraic = algebraic, right? For Pow, we'll have to have special cases like https://github.com/sympy/symp 8000 y/blob/ef3d570ac8f9b76855351bb712f8dbe2f1b2c69a/sympy/core/power.py#L1383
There was a problem hiding this comment.
grepping _eval_is_algebraic in sympy will give you all the rules that sympy implements.
| for (const auto &arg : x.get_args()) { | ||
| arg->accept(*this); | ||
| if (not is_true(is_algebraic_)) { | ||
| is_algebraic_ = tribool::indeterminate; |
There was a problem hiding this comment.
This becomes indeterminate only if there are two numbers which are not algebraic. If there's only one number that is not algebraic, it's false.
There was a problem hiding this comment.
Good catch! algebraic + transcendental = transcendental
There was a problem hiding this comment.
Add should be good now
|
I think further enhancements could go into future PR:s. Could we merge this? |
|
@isuruf Thanks for reviewing |
No description provided.