8000 Fix Mul canonical to match that of Pow canonical by bocklund · Pull Request #1900 · symengine/symengine · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix Mul canonical to match that of Pow canonical #1900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 3, 2022
Merged

Fix Mul canonical to match that of Pow canonical #1900

merged 3 commits into from
Apr 3, 2022

Conversation

bocklund
Copy link
Contributor

Test case from #1899

bocklund
bocklund commented Mar 30, 2022
View reviewed changes
@isuruf isuruf changed the title Add failing test for xreplace mul(real_double, symbol) Fix Mul handling of real**int Mar 30, 2022
@isuruf isuruf requested a review from a team March 30, 2022 18:57
@isuruf isuruf changed the title Fix Mul handling of real**int Fix Mul canonical to match that of Pow canonical Mar 30, 2022
bocklund added a commit to bocklund/pycalphad-xml that referenced this pull request Mar 31, 2022
@bocklund
Fix database equality test
bae18ad 
Needs symengine/symengine#1900
@rikardn
Copy link
Contributor
rikardn commented Apr 2, 2022

Good work! Should the new rules for canonicalization be documented in mul.h?

@isuruf
Copy link
Member
isuruf commented Apr 2, 2022

The rule is already there.

symengine/symengine/mul.h

Lines 51 to 54 in 562c957

* When key and value are numeric and one of them is inexact
Mul(2, {{3, 0.5}, {x, 2}}) -> Mul(3.464..., {x, 2}})

rikardn
rikardn approved these changes Apr 3, 2022
View reviewed changes
Copy link
Contributor
@rikardn rikardn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, then I have no comments. This looks good.

@isuruf isuruf merged commit 0cac84a into symengine:master Apr 3, 2022
@isuruf
Copy link
Member
isuruf commented Apr 3, 2022

Thanks for the test @bocklund and for the review @rikardn

@isuruf isuruf mentioned this pull request Apr 3, 2022
Closed
@bocklund bocklund deleted the xreplace-mul-equality branch April 3, 2022 16:11
@bocklund bocklund mentioned this pull request Apr 20, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rikardn rikardn rikardn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bocklund @rikardn @isuruf
0