8000 Comparing v2.9.0...v2.9.1 · symfony/ux · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: symfony/ux
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v2.9.0
Choose a base ref
...
head repository: symfony/ux
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v2.9.1
Choose a head ref
  • 12 commits
  • 38 files changed
  • 2 contributors

Commits on May 26, 2023

  1. Configuration menu
    Copy the full SHA
    5827da0 View commit details
    Browse the repository at this point in the history
  2. [Site] Upgrading deps

    weaverryan committed May 26, 2023
    Configuration menu
    Copy the full SHA
    cec9422 View commit details
    Browse the repository at this point in the history

Commits on May 30, 2023

  1. Configuration menu
    Copy the full SHA
    34e7ec1 View commit details
    Browse the repository at this point in the history
  2. bug #911 More precisely initializing services/config for asset mapper…

    … (weaverryan)
    
    This PR was squashed before being merged into the 2.x branch.
    
    Discussion
    ----------
    
    More precisely initializing services/config for asset mapper
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | yes
    | New feature?  | no
    | Tickets       | Fix #907
    | License       | MIT
    
    Hi!
    
    A few fixes for the new 2.9 version, which included a lot of under-the-hood changes to support asset mapper. These shouldn't be noticed by users and hopefully this will smooth out the final bumps:
    
    A) Avoid prepending the `asset_mapper` config unless FWBundle 6.3 is present. I don't love the solution - but it should work well enough, especially as this applies to asset mapper users and that is still experimental.
    
    B) Avoid registering a few asset mapper services that, on older versions of PHP/Symfony, may cause a container explosion due to a trait that won't be present.
    
    C) Plug some holes in the CI to test lower deps. The CI really needs to become much more dynamic than it is now, but this makes sure that all packages are tested for highest/lowest deps.
    
    Cheers!
    
    Commits
    -------
    
    34e7ec1 More precisely initializing services/config for asset mapper
    weaverryan committed May 30, 2023
    Configuration menu
    Copy the full SHA
    b31ef35 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0e94fec View commit details
    Browse the repository at this point in the history
  4. bug #910 [LiveComponent] Fix array valued checkboxes change event han…

    …dling (welcoMattic)
    
    This PR was squashed before being merged into the 2.x branch.
    
    Discussion
    ----------
    
    [LiveComponent] Fix array valued checkboxes change event handling
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | no
    | New feature?  | yes <!-- please update src/**/CHANGELOG.md files -->
    | Tickets       | Fix #906
    | License       | MIT
    
    As described in the linked issue, the event `change` of checkboxes weren't fully triggered (it didn't trigger AJAX request). It was because of the always-equals values of the pre-checked value attribute of the element and the after-change-event value of the element.
    
    Thanks `@Jim56450` for the help!
    
    Commits
    -------
    
    0e94fec [LiveComponent] Fix array valued checkboxes change event handling
    weaverryan committed May 30, 2023
    Configuration menu
    Copy the full SHA
    9d6c9cc View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    5144b71 View commit details
    Browse the repository at this point in the history
  6. bug #912 Skip test if FWBundle 6.3 or higher is NOT available (weaver…

    …ryan)
    
    This PR was merged into the 2.x branch.
    
    Discussion
    ----------
    
    Skip test if FWBundle 6.3 or higher is NOT available
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | yes
    | New feature?  | no
    | Tickets       | None
    | License       | MIT
    
    If FWBundle 6.2 or lower is installed, then there is no AssetMapper support, so skip the test.
    
    Cheers!
    
    Commits
    -------
    
    5144b71 Skip test if FWBundle 6.3 or higher is NOT available
    weaverryan committed May 30, 2023
    Configuration menu
    Copy the full SHA
    867a489 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    71abb6f View commit details
    Browse the repository at this point in the history
  8. minor #908 [StimulusBundle] Marking only the AssetMapper integration …

    …as experimental (weaverryan)
    
    This PR was squashed before being merged into the 2.x branch.
    
    Discussion
    ----------
    
    [StimulusBundle] Marking only the AssetMapper integration as experimental
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | yesish
    | New feature?  | no
    | Tickets       | Addresses #907 (comment)
    | License       | MIT
    
    StimulusBundle should not really be experimental. The `stimulus_*` Twig functions were ported from WebpackEncoreBundle and should work the same (if they don't, that would be a bug).
    
    The only part that should be experimental is the AssetMapper integration.
    
    Cheers!
    
    Commits
    -------
    
    71abb6f [StimulusBundle] Marking only the AssetMapper integration as experimental
    weaverryan committed May 30, 2023
    Configuration menu
    Copy the full SHA
    1043fb1 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    88f1f05 View commit details
    Browse the repository at this point in the history
  10. bug #914 [TwigComponent] Fix breaking (deprecation instead) when usin…

    …g .add() + StimulusBundle (weaverryan)
    
    This PR was squashed before being merged into the 2.x branch.
    
    Discussion
    ----------
    
    [TwigComponent] Fix breaking (deprecation instead) when using .add() + StimulusBundle
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | yes
    | New feature?  | no
    | Tickets       | None - reported on Slack.
    | License       | MIT
    
    Accidental break if upgrading to use new StimulusBundle, but still using `attributes.add(stimulus_controller())`.
    
    Cheers!
    
    Commits
    -------
    
    88f1f05 [TwigComponent] Fix breaking (deprecation instead) when using .add() + StimulusBundle
    weaverryan committed May 30, 2023
    Configuration menu
    Copy the full SHA
    42b4665 View commit details
    Browse the repository at this point in the history
Loading
0