More precisely initializing services/config for asset mapper #911
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weaverryan
commented
May 30, 2023
| return false; | ||
| } | ||
|
|
||
| return is_file($bundlesMetadata['FrameworkBundle']['path'].'/Resources/config/asset_mapper.php'); |
There was a problem hiding this comment.
@stof I don't love this solution, but I can't think of a better option. I'm wondering if, in asset-mapper 6.4, we should allow a service-based way of adding "paths" instead of relying on prepending.
There was a problem hiding this comment.
I don't have a better idea for that for now
|
Low deps on 8.1 are failing but should be good (I'll verify after the merge). The CI matrix doesn't patch (yet) cross-dependencies as well as symfony/symfony, so those bundles are not using StimulusBundle from this PR and are thus failing due to its prepend configuration acting when it shouldn't. |
2c218f9 to
34e7ec1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
A few fixes for the new 2.9 version, which included a lot of under-the-hood changes to support asset mapper. These shouldn't be noticed by users and hopefully this will smooth out the final bumps:
A) Avoid prepending the
asset_mapperconfig unless FWBundle 6.3 is present. I don't love the solution - but it should work well enough, especially as this applies to asset mapper users and that is still experimental.B) Avoid registering a few asset mapper services that, on older versions of PHP/Symfony, may cause a container explosion due to a trait that won't be present.
C) Plug some holes in the CI to test lower deps. The CI really needs to become much more dynamic than it is now, but this makes sure that all packages are tested for highest/lowest deps.
Cheers!