[TwigComponent] Fix lexer to escape attribute name when it contains dashes #837
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WebMamba
reviewed
May 3, 2023
| @@ -200,7 +200,7 @@ private function consumeAttributes(string $componentName): string | |||
| $attributeValue = $this->consumeAttributeValue($quote); | |||
| } | |||
|
|
|||
| $attributes[] = sprintf('%s: %s', $key, $attributeValue); | |||
| $attributes[] = sprintf('%s: %s', str_contains($key, '-') ? "'$key'" : $key, $attributeValue); | |||
There was a problem hiding this comment.
Maybe we should escape all the attributes. We can have the same issue with names containing : for example
There was a problem hiding this comment.
Yeah i forgot about colons. Tried to escape always but then some of tests throws:
2) Symfony\UX\TwigComponent\Tests\Unit\TwigPreLexerTest::testPreLex with data set "component_with_embedded_component_inside_block" ('<twig:foo><twig:block name="f...g:foo>', '{% component 'foo' %}{% block...ent %}')
Twig\Error\SyntaxError: Expected block name at line 1.
|
Very nice - thank you @norkunas! We may hit other edge cases and need to escape more. I'm not too worried - that test suite is getting more and more cases all the time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello :) back from holidays and now testing new features, so this is the second thing I've found.
Will open an issue about the first one.