[Autocomplete] When min chars is not set, keep loading after initial load #919
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AE62
4ca8746 to
30a1e7d
Compare
javiereguiluz
added a commit
to javiereguiluz/EasyAdminBundle
that referenced
this pull request
Jun 2, 2023
This PR was squashed before being merged into the 4.x branch. Discussion ---------- Compat for newer doctrine/lexer Hi! I noticed a deprecation this morning on UX and fixed it there - symfony/ux#919. Since I stole this code from this library, I thought I should return the fix ;). Cheers! Commits ------- 3788e0b Compat for newer doctrine/lexer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps with the case where you type 3 characters, get a load, then backspace (or clear all the characters) and loading stops and you can't get new options.
You can see the current behavior by going to https://ux.symfony.com/autocomplete, typing "ban", then backspacing. You will only see "banana" as an option, even if you clear it, unless you guess the first 3 chars of some other option.
Cheers!