8000 [Map] Explicitly require StimulusBundle in Bridges, fix tests by Kocal · Pull Request #2207 · symfony/ux · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[Map] Explicitly require StimulusBundle in Bridges, fix tests #2207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 25, 2024
Merged

[Map] Explicitly require StimulusBundle in Bridges, fix tests #2207

merged 2 commits into from
Sep 25, 2024

Conversation

Kocal
Copy link
Member
@Kocal Kocal commented Sep 25, 2024
Q A
Bug fix? no
New feature? no
Issues Fix #...
License MIT

Follows #2180.

When installing a Map Bridge dependencies, the StimulusBundle was not the one from the PR's branch but from 2.x, and so tests didn't fail in #2180 but started to fail after merging:

image

@carsonbot carsonbot added Map Status: Needs Review Needs to be reviewed labels Sep 25, 2024
@Kocal Kocal changed the title [Map] Explicitly require StimulusBundle in Bridges [Map] Explicitly require StimulusBundle in Bridges, fix tests Sep 25, 2024
@Kocal Kocal merged commit e51918f into symfony:2.x Sep 25, 2024
59 checks passed
@Kocal Kocal deleted the fix/map-bridges-tests branch September 25, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Map Status: Needs Review Needs to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kocal @carsonbot
0