8000 [AutoComplete] Note form requirements by MrYamous · Pull Request #2295 · symfony/ux · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[AutoComplete] Note form requirements #2295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 24, 2024
Merged

[AutoComplete] Note form requirements #2295

merged 1 commit into from
Oct 24, 2024

Conversation

MrYamous
Copy link
Contributor
Q A
Bug fix? no
New feature? no
Issues Fix #2252
License MIT

@smnandre
Copy link
Member

Thank you for this PR!

Most users likely already have the Form component installed when they read this documentation, or they’ve just installed Symfony following the installation guide, which includes the component by default. So, I’m not sure it’s necessary to include a "composer require ..." block here.

Instead, we could add a link to the Symfony Form documentation within the text. What do you think?

@smnandre smnandre added the docs Improvements or additions to documentation label Oct 23, 2024
@MrYamous
Copy link
Contributor Author

Thank you for this PR!

Most users likely already have the Form component installed when they read this documentation, or they’ve just installed Symfony following the installation guide, which includes the component by default. So, I’m not sure it’s necessary to include a "composer require ..." block here.

Instead, we could add a link to the Symfony Form documentation within the text. What do you think?

I fully agree with your point, that's probably overkill and adding a bit of noise to the doc.
I've updated to remove the composer require part and insert Symfony Form link to the original sentence

smnandre
smnandre approved these changes Oct 24, 2024
View reviewed changes
Copy link
Member
@smnandre smnandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thank you @MrYamous !

@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels Oct 24, 2024
@javiereguiluz javiereguiluz force-pushed the autocomplete/add-form-requirements branch from f76cf24 to a55f193 Compare October 24, 2024 09:15
@javiereguiluz javiereguiluz merged commit 4d220b7 into symfony:2.x Oct 24, 2024
2 checks passed
@javiereguiluz
Copy link
Member

Thanks Matthieu!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smnandre smnandre smnandre approved these changes

Assignees
No one assigned
Labels
Autocomplete docs Improvements or additions to documentation Status: Reviewed Has been reviewed by a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[AutoComplete] Weak dependency on symfony/form
4 participants
@MrYamous @smnandre @javiereguiluz @carsonbot
0