8000 fix(rest-api): tests with amounts of chains/tokens by ChiTimesChi · Pull Request #3534 · synapsecns/sanguine · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(rest-api): tests with amounts of chains/tokens #3534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix(rest-api): tests with amounts of chains/tokens #3534

wants to merge 1 commit into from

Conversation

ChiTimesChi
Copy link
Collaborator
@ChiTimesChi ChiTimesChi commented Feb 24, 2025 •
edited by coderabbitai bot
Loading

Description
A clear and concise description of the features you're adding in this pull request.

Additional context
Add any other context about the problem you're solving.

Metadata

  • Fixes #[Link to Issue]

Summary by CodeRabbit

  • Tests
    • Updated test expectations to reflect the new tokens list in the API response, ensuring additional tokens are accurately returned.
    • Revised test criteria for the available chains count, now verifying an updated total that aligns with current data.

@coderabbitai coderabbitai
Copy link
Contributor
coderabbitai bot commented Feb 24, 2025 •
edited
Loading

Walkthrough

The changes update two API endpoint tests within the REST API package. The destination tokens route test now expects an expanded token array with three additional tokens and modifies the response length verification accordingly. Additionally, the index route test adjusts the expected length of the available chains property. No public entity declarations were altered.

Changes

File(s) Change Summary
packages/.../destinationTokensRoute.test.ts Updated expected tokens for chain '534352' by adding USDC-130, USDC-480, and USDC-80094. Changed expected response length from 6 to 8.
packages/.../indexRoute.test.ts Modified expected length of availableChains from 23 to 25 in the test assertions.

Possibly related PRs

Suggested reviewers

  • trajan0x
  • Defi-Moses
  • abtestingalpha

Poem

I’m a rabbit on the run,
Hopping with tokens under the sun,
Tests updated in a line-by-line dance,
API leaps forward with every chance,
Celebrating changes with joyful delight,
Codes and carrots—everything’s bright!
🐇🌟

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7559451 and c77747c.

📒 Files selected for processing (2)
  • packages/rest-api/src/tests/destinationTokensRoute.test.ts (2 hunks)
  • packages/rest-api/src/tests/indexRoute.test.ts (1 hunks)
🧰 Additional context used
🧠 Learnings (2)
packages/rest-api/src/tests/indexRoute.test.ts (1) 
Learnt from: abtestingalpha
PR: synapsecns/sanguine#3126
File: packages/rest-api/src/tests/indexRoute.test.ts:21-31
Timestamp: 2024-11-12T03:37:02.230Z
Learning: In this project, tests intentionally use hardcoded values for counts to capture changes in the number of available chains and tokens.
packages/rest-api/src/tests/destinationTokensRoute.test.ts (1) 
Learnt from: abtestingalpha
PR: synapsecns/sanguine#3126
File: packages/rest-api/src/tests/indexRoute.test.ts:21-31
Timestamp: 2024-11-12T03:37:02.230Z
Learning: In this project, tests intentionally use hardcoded values for counts to capture changes in the number of available chains and tokens.
⏰ Context from checks skipped due to timeout of 90000ms (7)
  • GitHub Check: test
  • GitHub Check: SonarCloud
  • GitHub Check: lint
  • GitHub Check: changesets-integrity-checker
  • GitHub Check: test
  • GitHub Check: lint
  • GitHub Check: Cloudflare Pages
🔇 Additional comments (2)
packages/rest-api/src/tests/indexRoute.test.ts (1)

27-27: LGTM! The updated chain count aligns with project testing strategy.

The increase in expected chain count from 23 to 25 correctly reflects the addition of new chains, following the project's intentional use of hardcoded values to capture such changes.

packages/rest-api/src/tests/destinationTokensRoute.test.ts (1)

54-64:

✅ Verification successful

LGTM! The updated token count and documentation are consistent.

The changes correctly reflect the addition of three new USDC tokens (USDC-130, USDC-480, USDC-80094) by:

  1. Updating the documentation comment with the complete token list
  2. Adjusting the expected length assertion from 6 to 8

Let's verify that these tokens are properly configured in the constants:

🏁 Script executed:

#!/bin/bash
# Description: Verify USDC token configuration for the new chains

# Search for USDC token configurations for chains 130, 480, and 80094
rg -A 5 "USDC.*addresses.*(?:130|480|80094)"

Length of output: 65583

LGTM! The updated test clearly reflects the intended changes.

  • The documentation comment now correctly lists all 8 tokens: USDC-1, USDC-10, USDC-130, USDC-480, USDC-8453, USDC-42161, USDC-59144, and USDC-80094.
  • The assertion has been adjusted from 6 to 8 to match the complete token list.
  • A quick verification using the search script shows that the new token chains (130, 480, 80094) are present in the configuration (as evidenced by entries in the contract info).
✨ Finishing Touches
  • 📝 Generate Docstrings (Beta)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

Deploying sanguine-fe with  Cloudflare Pages  Cloudflare Pages

Latest commit: c77747c
Status: ✅  Deploy successful!
Preview URL: https://09491a57.sanguine-fe.pages.dev
Branch Preview URL: https://fix-rest-api-amount-tests.sanguine-fe.pages.dev

View logs

@ChiTimesChi
Copy link
Collaborator Author

Closing: this is fixed in #3530

@ChiTimesChi ChiTimesChi deleted the fix/rest-api-amount-tests branch February 25, 2025 00:05
This was referenced Feb 25, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trajan0x trajan0x Awaiting requested review from trajan0x trajan0x is a code owner

@Defi-Moses Defi-Moses Awaiting requested review from Defi-Moses Defi-Moses is a code owner

Assignees
No one assigned
Labels
size/xs Sol Typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ChiTimesChi
0