fix(sdk-router): restrict `fromAmount` to `string` in the exported intent parameters #3645

ChiTimesChi · 2025-04-01T15:49:08Z

Description
A clear and concise description of the features you're adding in this pull request.

Additional context
Add any other context about the problem you're solving.

Metadata

Fixes #[Link to Issue]

Summary by CodeRabbit

Refactor
- Standardized the handling of numerical token amounts across bridging, intent, and swap operations to ensure consistent representation and improve reliability.
Documentation
- Enhanced clarity for transaction data structures with updated documentation to better guide usage.

vercel · 2025-04-01T15:49:13Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
sanguine	❌ Failed (Inspect)			Apr 1, 2025 3:49pm

coderabbitai · 2025-04-01T15:49:16Z

Walkthrough

This pull request updates how the fromAmount property is handled across several modules in the SDK router. In operations for bridging, intent quoting, and swapping, the conversion of fromAmount to a string using toString() has been removed so that the original numeric type is preserved. In addition, type definitions in the bridge, intent, and swap modules have been updated to represent monetary values as strings rather than using BigNumber/BigNumberish. A new JSDoc comment for the PopulatedTx type has also been added to clarify its structure.

Changes

Files	Change Summary
`packages/sdk-router/src/operations/{bridge, intent, swap}.ts`	Removed explicit `toString()` conversion for `fromAmount`, preserving its original numeric type in quote and swap functions.
`packages/sdk-router/src/types/{bridge, intent, swap}.ts`	Updated type definitions by converting properties such as `fromAmount`, `expectedToAmount`, `minToAmount`, and `gasDropAmount` from BigNumber/BigNumberish to `string`, and adjusted the transaction type from `PopulatedTransaction` to `PopulatedTx`.
`packages/sdk-router/src/types/misc.ts`	Added a JSDoc comment block for the `PopulatedTx` type, describing its properties and intended usage.

Possibly related PRs

feat(synapse-interface): bridge quote state validations #3019: Addresses similar modifications to the fromAmount property in bridge functionality.
fix(sdk-router): export intent types #3620: Involves changes to fromAmount handling in intent operations, mirroring the modifications in this PR.
chore(sdk-router): cleanup types, remove unused utilities #3600: Adjusts type definitions by transitioning from BigNumberish to string for swap-related amounts.

Poem

I hopped through lines of shifting code,
Carrots and bytes along my road.
No more string traps where numbers should play,
The SDK blooms in a brighter way.
With each little tweak, my heart feels light—
A rabbit's delight in coding tonight!

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b5a153f and 3bc0178.

📒 Files selected for processing (7)

packages/sdk-router/src/operations/bridge.ts (1 hunks)
packages/sdk-router/src/operations/intent.ts (2 hunks)
packages/sdk-router/src/operations/swap.ts (2 hunks)
packages/sdk-router/src/types/bridge.ts (4 hunks)
packages/sdk-router/src/types/intent.ts (4 hunks)
packages/sdk-router/src/types/misc.ts (1 hunks)
packages/sdk-router/src/types/swap.ts (4 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (4)

GitHub Check: test
GitHub Check: changesets-integrity-checker
GitHub Check: lint
GitHub Check: Cloudflare Pages

🔇 Additional comments (17)

packages/sdk-router/src/types/intent.ts (4)

8-9: Improved type safety by changing fromAmount to string in IntentParameters.

The change from BigNumberish to string for fromAmount ensures consistent type handling and prevents potential data conversion issues when dealing with monetary values.

Also applies to: 20-21

36-37: Standardized monetary value types in IntentQuote.

Converting fromAmount, expectedToAmount, and minToAmount from BigNumber to string creates consistency in how monetary values are represented across the SDK router. This approach prevents precision loss and improves interoperability with external systems.

Also applies to: 48-49, 39-40, 51-52

62-67: Standardized monetary value types in IntentStep.

All monetary values (fromAmount, expectedToAmount, minToAmount, and gasDropAmount) now use the string type instead of BigNumber. This change, along with updated JSDoc comments, ensures consistency throughout the codebase and better type safety when handling numeric values.

Also applies to: 76-81, 70-71, 84-85

71-72: Added clarifying JSDoc comment for the PopulatedTx type.

Adding documentation for the tx property of type PopulatedTx improves code maintainability by clarifying its purpose and usage.

packages/sdk-router/src/operations/swap.ts (2)

31-32: Removed unnecessary string conversion in getEmptyQuoteV2.

This change aligns with the updated type definitions where fromAmount is now expected to be a string. Removing the implicit .toString() conversion maintains the type integrity and prevents redundant operations.

95-96: Removed unnecessary string conversion in swapV2.

This change complements the type updates in the interface definitions where fromAmount is now expected to be a string. Removing the implicit .toString() conversion maintains type consistency throughout the codebase.

packages/sdk-router/src/operations/intent.ts (2)

38-39: Removed unnecessary string conversion in _getSameChainIntentQuotes.

Directly using params.fromAmount without conversion aligns with the updated type definitions where fromAmount is now expected to be a string. This ensures type consistency and removes redundant operations.

87-88: Removed unnecessary string conversion in _getCrossChainIntentQuotes.

This change is consistent with the updated type definitions and with the other files' changes. Directly assigning params.fromAmount without string conversion ensures type consistency across the codebase.
packages/sdk-router/src/operations/bridge.ts (2)

128-129: Removed unnecessary string conversion in _collectV1Quotes.

This change aligns with the updated type definitions where fromAmount is now expected to be a string. Removing the implicit .toString() conversion maintains type consistency throughout the bridge operations.

1-589:
✅ Verification successful

Verify the impact of type changes across consuming code.

The changes to the fromAmount parameter are consistent across all files, but it would be good to ensure that all consumers of these APIs are prepared to handle fromAmount as a string rather than BigNumberish or BigNumber.

🏁 Script executed:
#!/bin/bash
# Search for places where `fromAmount` is being used with BigNumber operations
echo "Checking for potential BigNumber operations being performed on fromAmount:"
rg -A 2 -B 2 "\.fromAmount\.(add|sub|mul|div|gt|lt|eq|gte|lte|isZero|toString)"

# Check for places where numeric values are passed to parameters that now expect strings
echo "Checking for numeric literals being passed to fromAmount:"
rg -A 2 -B 2 "fromAmount: \d+"

# Check for BigNumber instances being directly assigned to fromAmount
echo "Checking for BigNumber instances being assigned to fromAmount:"
rg -A 2 -B 2 "fromAmount: BigNumber\.(from|[a-zA-Z]+\()"
Length of output: 4263
Type Conversion Check for fromAmount: No Further Action Required

I verified that all consuming files correctly handle the change to pass fromAmount as a string. In particular:

Consumers converting fromAmount to a BigNumber (using BigNumber.from(fromAmount)) are consistently applied in files such as response.ts, noOpEngine.ts, kyberSwapEngine.ts, liFiEngine.ts, and defaultPoolsEngine.ts.

The usage of input.fromAmount.toString() in paraSwapEngine.ts also works properly with a string value.

No numeric literals are directly passed to fromAmount, ensuring type consistency across the codebase.

Based on these findings, all consumers appear prepared for the change, so no additional modifications are required.
packages/sdk-router/src/types/misc.ts (1)

4-10: Great addition of JSDoc documentation!

The added documentation for the PopulatedTx type provides clear explanations for each property, making it easier to understand their purpose and expected format. This enhances code readability and improves developer experience.

packages/sdk-router/src/types/swap.ts (3)

24-24: Good change to use string type for monetary values

Changing fromAmount to use string instead of BigNumberish is a good approach for representing financial values. Strings avoid precision issues that can occur with JavaScript numbers and provide a more consistent API for blockchain interactions.

Also applies to: 34-34

48-51: Consistent type documentation update

The JSDoc updates for fromAmount, expectedToAmount, and minToAmount properly reflect the change to string representation, maintaining documentation consistency with the actual type definitions.

55-55: Appropriate update to PopulatedTx reference

Updating the tx property reference to use PopulatedTx aligns with the properly documented type in misc.ts. This ensures type consistency throughout the codebase.

Also applies to: 68-68

packages/sdk-router/src/types/bridge.ts (3)

41-41: Good change to use string type for fromAmount

Converting the fromAmount type to string in BridgeV2Parameters aligns with the changes made in other parts of the codebase, ensuring consistency in how monetary values are represented.

Also applies to: 52-52

67-71: Consistent monetary value type changes

The updates to JSDoc comments for fromAmount, expectedToAmount, and minToAmount to indicate string type is consistent with their actual type definitions. This is a good practice for maintaining accurate documentation.

75-76: Appropriate conversion of remaining monetary fields

Changing gasDropAmount to string type and updating the tx reference to PopulatedTx completes the standardization of types across the bridge-related interfaces. This creates a more consistent API.

Also applies to: 90-91

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai plan to trigger planning for file edits and PR creation.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

cloudflare-workers-and-pages · 2025-04-01T15:53:58Z

Deploying sanguine-fe with Cloudflare Pages

Latest commit:	`3bc0178`
Status:	✅ Deploy successful!
Preview URL:	https://37048393.sanguine-fe.pages.dev
Branch Preview URL:	https://fix-sdk-intent-parameters.sanguine-fe.pages.dev

View logs

codecov · 2025-04-01T15:56:30Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 12.79087%. Comparing base (b5a153f) to head (3bc0178).
Report is 1 commits behind head on master.

Additional details and impacted files

@@              Coverage Diff              @@
##              master       #3645   +/-   ##
=============================================
  Coverage   12.79087%   12.79087%           
=============================================
  Files            307         307           
  Lines          33563       33563           
  Branches         205         205           
=============================================
  Hits            4293        4293           
  Misses         28785       28785           
  Partials         485         485

Flag	Coverage Δ
packages	`68.49657% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov · 2025-04-01T17:22:46Z

Bundle Report

Changes will decrease total bundle size by 114 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes

Bundle name	Size	Change
sdk-router-@synapsecns/sdk-router-esm	367.12kB	-55 bytes (-0.01%) ⬇️
sdk-router-@synapsecns/sdk-router-cjs	164.91kB	-59 bytes (-0.04%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sdk-router-@synapsecns/sdk-router-esm

Assets Changed:

8000

Asset Name	Size Change	Total Size	Change (%)
`sdk-router.esm.js`	-55 bytes	367.12kB	-0.01%

Files in sdk-router.esm.js:

./src/types/swap.ts → Total Size: 0 bytes
./src/operations/bridge.ts → Total Size: 32.05kB
./src/types/misc.ts → Total Size: 0 bytes
./src/operations/intent.ts → Total Size: 8.15kB
./src/types/bridge.ts → Total Size: 0 bytes
./src/operations/swap.ts → Total Size: 8.34kB
./src/types/intent.ts → Total Size: 0 bytes

view changes for bundle: sdk-router-@synapsecns/sdk-router-cjs

Assets Changed:

Asset Name	Size Change	Total Size	Change (%)
`sdk-router.cjs.production.min.js`	-59 bytes	164.91kB	-0.04%

Files in sdk-router.cjs.production.min.js:

./src/types/bridge.ts → Total Size: 0 bytes
./src/types/swap.ts → Total Size: 0 bytes
./src/types/intent.ts → Total Size: 0 bytes
./src/types/misc.ts → Total Size: 0 bytes
./src/operations/intent.ts → Total Size: 8.16kB
./src/operations/bridge.ts → Total Size: 31.84kB
./src/operations/swap.ts → Total Size: 8.36kB

* Ft/ponder ix hyp evm (#3571) * add hyperevm to ponder ix * addtl hypevm chain config --------- Co-authored-by: parodime <noreply@protochainresearch.com> * Publish - @synapsecns/rfq-indexer-api@1.1.0 - @synapsecns/rfq-indexer@0.0.7 * ponder ix - set hyperEVM block range to 50 * fix: hyperEVM block range * ponder ix - alter hype start block * Fix multi-architecture build for Hyperliquid Node Image (#3574) * hl docker image * fix(workflow): move date tag creation to separate step in hyperliquid workflow 🤖 Generated with Claude Code Co-Authored-By: Claude <noreply@anthropic.com> * fix(workflow): remove load flag and use local image for tagging in hyperliquid workflow * fix(workflow): use build-push-action for date tagging in hyperliquid workflow * feat(workflow): add multi-architecture support and mainnet image build for hyperliquid * fix(workflow): update hyperliquid workflow to use local Dockerfile for better multi-arch support * fix(hyperliquid): update binary URL paths to match node documentation * fix(hyperliquid): temporarily skip GPG verification due to inconsistent path issues * fix(hyperliquid): always use Testnet binary since Mainnet binary is not publicly accessible * fix(hyperliquid): use correct URL for Mainnet binary --------- Co-authored-by: Trajan0x <trajan0x@users.noreply.github.com> * feat: Swap Engines [SYN-29] [SYN-35] (#3563) * feat: SIR binding, StepParams, ZapData encoding * feat: engine quote/route structs * feat: slippage utils * feat: no-op engine * feat: add Default Engine * feat: Kyber, Li.FI engines * feat: paraSwap module * feat: SwapEngineSet * feat: add SwapEngineSet to SDK * feat: Synapse Intent Router * feat: expose swapV2 * feat: add swapV2 controller * feat: add swapV2 route * fix: null behaviour consistent with bridge route * fix: remove originUserAddress for swapV2 * feat: swapV2 to use native amounts (wei) * fix: swap/v2 route * fix: tests * feat: add production contracts * chore: reorder KyberSwap chains, add bnerachain * feat: expand list of supported chains for /swap/v2 * refactor: use named paramters for swapV2 * fix: set default slippage to 0.5%; stringify tx.value * chore: generate docs * Publish - @synapsecns/rest-api@1.10.0 - @synapsecns/sdk-router@0.13.0 - @synapsecns/synapse-interface@0.42.6 - @synapsecns/widget@0.9.17 - @synapsecns/rfq-indexer@0.0.8 * fix: mockCallRevert internal revert (#3575) * Publish - @synapsecns/contracts-rfq@0.16.2 * feat(contracts-rfq): deploy SIR [SYN-29] (#3573) * fix: adjust comment for #3467 * chore: mainnet -> ethereum * feat: update deploy scripts, prepare create2 salts * chore: add deployments from new chains * chore: add chain IDs to foundry.toml * chore: add utility scripts * deploy: SIR and periphery on 12 chains * deploy: SIR at 0x512000...000512 address * fix: update SIR address * Publish - @synapsecns/contracts-rfq@0.17.0 - @synapsecns/rest-api@1.10.1 - @synapsecns/sdk-router@0.14.0 - @synapsecns/synapse-interface@0.42.7 - @synapsecns/widget@0.9.18 * feat: SDK new chains [SYN-45] (#3535) * feat: add HyperEVM to sdk-router * feat: use staging RFQ API [REVERT LATER] * feat: add HYPE-USDC, HYPE-ETHto the bridge map * fix: add HYPE, HyperEVM to rest-api * feat: update rest-api bridge map * chore: add envs for api urls (#3537) Co-authored-by: Trajan0x <trajan0x@users.noreply.github.com> * chore: make prod RFQ API the default value * feat: support multiple RFQ APIs * fix: don't report negative bridge fee for RFQ * test: adjus the amount of token pairs for USDC --------- Co-authored-by: trajan0x <83933037+trajan0x@users.noreply.github.com> Co-authored-by: Trajan0x <trajan0x@users.noreply.github.com> * Publish - @synapsecns/rest-api@1.11.0 - @synapsecns/sdk-router@0.15.0 - @synapsecns/synapse-interface@0.43.0 - @synapsecns/widget@0.9.19 * fix: hide slippage between different type of assets for now [SYN-39] (#3590) * Publish - @synapsecns/synapse-interface@0.43.1 * Support Swap V2 endpoint on Synapse REST client (#3593) * fix(rest-api): swap v2 errors (#3594) * fix: check if tx is defined * chore: correct endpoint name in error * Publish - @synapsecns/rest-api@1.11.1 * feat: sdk/api bridgeV2 for SynapseRFQ [SYN-66] (#3588) * feat: scaffold bridgeV2 * feat: complete bridgeV2, scaffold module impls * feat: airdrop amount in bridgeV2 * feat: bridgeV2 for SynapseRFQ * fix: add more info to SwapEngine quotes, type assertions * feat: /bridge/v2 * chore: generate docs * refactor: steps params manipulation * feat: cap origin slippage * feat: cache getAllQuotes calls * fix(rest-api): improve bridge v2 response format - Replace BigNumber response objects with string values - Rename maxAmountOutStr to maxAmountOut for cleaner API - Update swagger documentation to reflect changes 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> * feat(restclient): add bridge v2 endpoint support - Add GetBridgeV2 and related parameters to REST client - Update type definitions for bridge v2 response format - Synchronize with recent bridge v2 API changes 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> --------- Co-authored-by: Claude <noreply@anthropic.com> * [DI-48] fix: replace vulnerable tj-actions actions with dorny/paths-filter (#3595) Replace all tj-actions actions (changed-files, verify-changed-files, branch-names) with secure alternatives to mitigate the security vulnerability. Used dorny/paths-filter for file checking and bash scripts for branch name detection. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> Co-authored-by: Trajan0x <trajan0x@users.noreply.github.com> * chore(rest-api): edit README to trigger republish (#3597) * Publish - @synapsecns/rest-api@1.12.0 * chore(sdk-router): edit README to trigger republish (#3598) * Publish - @synapsecns/rest-api@1.12.1 - @synapsecns/sdk-router@0.16.0 - @synapsecns/synapse-interface@0.43.2 - @synapsecns/widget@0.9.20 * chore(sdk-router): cleanup types, remove unused utilities (#3600) * feat: add Prettify utility type for better IDE type display Adds a Prettify<T> utility type that improves how types are displayed in the IDE: - Applied to union types to show all properties - Applied to Partial/Required patterns to show complete property set - Applied to complex types with optional properties 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> * chore(sdk-router): apply Prettify to complex types - Add Prettify utility type to intersection types and type modifiers - Create PartialZapDataV1 type for better reusability - Update function signatures to use new type definitions - Improve IDE display of complex types 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> * chore(sdk-router): remove unused entity files and utils Removed deprecated entity files and utility functions that are no longer needed in the SDK router package. These files were likely imported from another SDK and are not currently being used. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> * refactor(sdk-router): centralize utilities through utils/index.ts - Modified utils/index.ts to use export * from each utility module - Updated all imports to reference the centralized utils module instead of individual utility files - This change makes the codebase more maintainable and easier to refactor 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> * chore(sdk-router): enforce alphabetical ordering of imports - Added alphabetical ordering rule to ESLint configuration - Auto-fixed imports order in all files to comply with the new rule - This enforces a consistent import style throughout the codebase 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> * refactor(sdk-router): replace BigintIsh with ethers' BigNumberish Replace all occurrences of custom BigintIsh type with the standard BigNumberish from ethers.js. This standardizes the codebase by using established types from the core library. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> --------- Co-authored-by: Claude <noreply@anthropic.com> * Publish - @synapsecns/rest-api@1.12.2 - @synapsecns/sdk-router@0.16.1 - @synapsecns/synapse-interface@0.43.3 - @synapsecns/widget@0.9.21 * fix(rest-api,sdk-router): `/bridge/v2` and `swap/v2` endpoint standardisation [SYN-77] (#3602) * refactor: consistent params naming in swap/bridge V2 * feat: enrich SwapQuoteV2 * feat: enrich BridgeQuoteV2 * feat: update V2 endpoints in rest-api * chore: update the swagger docs * refactor: id ordering * chore: regenerate restclient * chore: fix example router address in `/swap/v2` response * fix: add swap module name, same token swaps * fix: unify swap/bridge module names in V2 only * chore: unified "module name" in rest-api * fix: remove string cast * fix: SDK tests * Apply suggestions from code review Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Publish - @synapsecns/rest-api@1.12.3 - @synapsecns/sdk-router@0.16.2 - @synapsecns/synapse-interface@0.43.4 - @synapsecns/widget@0.9.22 * chore(sdk-router): cleanup logging, engine priorities (#3610) * refactor: clean up engine priorities * chore: remove execution time logging * fix: adjust engine priorities * Publish - @synapsecns/rest-api@1.12.4 - @synapsecns/sdk-router@0.16.3 - @synapsecns/synapse-interface@0.43.5 - @synapsecns/widget@0.9.23 * feat(rest-api,sdk-router): intent endpoint [SYN-77] (#3613) * feat: scaffold `intent` function * feat: scaffold multiple txs in bridgeV2 * feat: optional `tokenOut` in bridge token candidate search * feat: allow multiple txs in `bridgeV2` * feat: single-chain swap intents * feat: cross-chain intents * feat: expose `/intent` endpoint * chore: generate swagger * fix: report all module names within the intent step * chore: rename into "default pools" engine * chore: update swagger, regenerate client * fix: prevent errors on unsupported RFQ routes in V2 endpoints * fix: block times, supported intent chains * fix: fromAmount string * Publish - @synapsecns/rest-api@1.13.0 - @synapsecns/sdk-router@0.17.0 - @synapsecns/synapse-interface@0.43.6 - @synapsecns/widget@0.9.24 * fix(sdk-router): export intent types (#3620) * fix: export intent types * fix: export bridge types * fix: export swap types * fix: imports in tests * Publish - @synapsecns/rest-api@1.13.1 - @synapsecns/sdk-router@0.17.1 - @synapsecns/synapse-interface@0.43.7 - @synapsecns/widget@0.9.25 * upgrading to reference cortex much more * adding new links etc * Publish - @synapsecns/bridge-docs@0.6.7 - @synapsecns/explorer-ui@0.5.15 - @synapsecns/synapse-interface@0.43.8 - @synapsecns/widget@0.9.26 * fix(sdk-router): exported slippage type (#3634) * fix: use slippagePercentage in exported types * fix: use slippage percentage in rest-api * Publish - @synapsecns/rest-api@1.13.2 - @synapsecns/sdk-router@0.17.2 - @synapsecns/synapse-interface@0.43.9 - @synapsecns/widget@0.9.27 * fix(sdk-router, rest-api): stringify BigNumber in exported V2 types [SYN-77] (#3636) * fix: stringify BigNumber in exported V2 types * fix: update bridge modules * fix: update V2 operations * fix: update rest-api * Publish - @synapsecns/rest-api@1.13.3 - @synapsecns/sdk-router@0.17.3 - @synapsecns/synapse-interface@0.43.10 - @synapsecns/widget@0.9.28 * Update bl * fix(sdk-router): restrict `fromAmount` to `string` in the exported intent parameters (#3645) * chore: fix existing documentation * fix: restrict fromAmount type to string in exported parameters * Publish - @synapsecns/rest-api@1.13.4 - @synapsecns/sdk-router@0.17.4 - @synapsecns/synapse-interface@0.43.11 - @synapsecns/widget@0.9.29 * fix(sdk-router): add decimals to intent steps (#3646) * refactor: isolate token decimals retrieval * fix: add decimal metadata to each intent step * fix: make tokenMetadataFetcher optional * Publish - @synapsecns/rest-api@1.13.5 - @synapsecns/sdk-router@0.17.5 - @synapsecns/synapse-interface@0.43.12 - @synapsecns/widget@0.9.30 * fix(sdk-router): add `HYPEREVM` to intents supported chains * chore: small change to publish 9abecbe (#3648) * Publish - @synapsecns/rest-api@1.13.6 - @synapsecns/sdk-router@0.17.6 - @synapsecns/synapse-interface@0.43.13 - @synapsecns/widget@0.9.31 * fix(sdk-router): swap engine improvements, remove cap on RFQ origin slippage (#3652) * fix: exclude RFQ sources on KyberSwap * fix: paraSwap partner, LiFi timing strategy * feat: use FBI for Route V2 zap data * fix: make minToAmount requied in SwapEngineRoute * fix: don't cap origin slippage * fix: don't use interceptor without origin swaps * Publish - @synapsecns/rest-api@1.13.7 - @synapsecns/sdk-router@0.17.7 - @synapsecns/synapse-interface@0.43.14 - @synapsecns/widget@0.9.32 * removing old routes and tokens * Publish - @synapsecns/bridge-docs@0.6.8 * Adding hyperevm to the explorer (#3647) * adding hyperevm [goreleaser] * updating chart color * fixing pricing issues [goreleaser] * fix for native tokens [goreleaser] * fixing bera weth [goreleaser] * removing all old fetcher changes * [goreleaser] * lint --------- Co-authored-by: parodime <jordan@protochainresearch.com> * Publish - @synapsecns/explorer-ui@0.5.16 * adding hyperevm to constants * Publish - @synapsecns/bridge-docs@0.6.9 - @synapsecns/explorer-ui@0.5.17 - @synapsecns/rest-api@1.13.8 - @synapsecns/synapse-constants@1.8.10 * Deprecate and remove go restclient module [SYN-88] (#3658) --------- Co-authored-by: Trajan0x <trajan0x@users.noreply.github.com> * SYN-86 Delete Old exporters and remove unused code (#3656) Co-authored-by: Trajan0x <trajan0x@users.noreply.github.com> * SYN-87 Remove SignOz functionality from opbot (#3657) * SYN-87 Remove SignOz functionality from opbot - Removed SignOz client and package - Removed SignOz configuration fields - Removed traceCommand dependent on SignOz - Updated README to remove SignOz references - Added CLAUDE.md for automated operations - Fixed formatting and ensured code builds correctly * update go.work.sum * Fix goimports formatting issues for linting * [goreleaser] * nuke signoz example [goreleaser] --------- Co-authored-by: Trajan0x <trajan0x@users.noreply.github.com> * feat(contracts-rfq): fast bridge interceptor [SYN-84] (#3649) * feat: scaffold FastBridgeInterceptor * test: add coverage * feat: implement interceptor * test: different decimals ratio * docs: improve FastBridgeInterceptor documentation - Add clear NatSpec documentation to both implementation and interface - Focus user documentation on integration aspects - Clarify contract behavior and edge cases - Follow Solidity documentation standards - Fix typo in interface documentation 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> * chore: fix lint * refactor: relabel percentage vars * build: deploy Interceptor on supported mainnets --------- Co-authored-by: Claude <noreply@anthropic.com> * Publish - @synapsecns/contracts-rfq@0.18.0 * feat(contracts-rfq): sir new deployments (#3662) * build: add new chains to config * chore: deploy on avax and polygon * Publish - @synapsecns/contracts-rfq@0.19.0 * fix(sdk-router): address utils, URLs in constructor, ParaSwap surplus (#3660) * fix: `handleNativeToken` non-checksummed address, reorganize * fix: export address utils * refactor: handleParams * test: ensure that 0xEE is working with integrations * feat: pass paraswap surplus to user * feat: allow passing URLs in SDK constructor * fix: use Gas.Zip contract deposit * fix: types * feat: intents with gas.zip * build: add sdk:stream script * feat: add Avax, Ploygon to intents chain ids * refactor: chainProviders init logic * fix: enforce gas.zip min/max usd value * Publish - @synapsecns/rest-api@1.13.9 - @synapsecns/sdk-router@0.17.8 - @synapsecns/synapse-interface@0.43.15 - @synapsecns/widget@0.9.33 * fix(sdk-router): faster intent quotes, time logging, Paraswap surplus [SYN-97] (#3672) * fix: make logExecutionTime more generic * chore: add execition time logging * fix: paraswap surplus * fix: use longer cache for RFQ available tokens, shorter cache for quotes * feat: getFastestQuote * chore: remove old getBestQuote * fix: timeouts * chore: fix incorrect comments * fix: make logging work with minimised package * fix: prevent unhandled rejections in quote processing - Improve _getFastestQuote to properly handle all promises even when returning early - Use Promise.allSettled in the background to ensure all rejections are caught - Maintain fast response time while avoiding unhandled promise rejections 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> * fix: ensure timing is logged even when methods throw errors - Wrap method execution in try/finally to log execution time in all cases - Ensure original errors are propagated properly - Simplify code with direct return in try block 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> * fix: ensure consistent cache keys in FastBridgeRouterSet - Fix cache key inconsistency in getAllQuotes method - Ensure cache keys match between get and set operations - Use enum values directly in cache key construction 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> * fix: variable shadowing --------- Co-authored-by: Claude <noreply@anthropic.com> * Publish - @synapsecns/rest-api@1.13.10 - @synapsecns/sdk-router@0.17.9 - @synapsecns/synapse-interface@0.43.16 - @synapsecns/widget@0.9.34 * fix(sdk-router): gas.zip block height (#3675) * feat: add latest block endpoint * fix: don't use gas.zip quotes for stale chains * fix: getBlock error cases * fix: safer API data manipulation * Publish - @synapsecns/rest-api@1.13.11 - @synapsecns/sdk-router@0.17.10 - @synapsecns/synapse-interface@0.43.17 - @synapsecns/widget@0.9.35 --------- Co-authored-by: parodime <jordan@protochainresearch.com> Co-authored-by: parodime <noreply@protochainresearch.com> Co-authored-by: parodime <parodime@users.noreply.github.com> Co-authored-by: trajan0x <83933037+trajan0x@users.noreply.github.com> Co-authored-by: Trajan0x <trajan0x@users.noreply.github.com> Co-authored-by: ChiTimesChi <ChiTimesChi@users.noreply.github.com> Co-authored-by: vro <168573323+golangisfun123@users.noreply.github.com> Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: defi-moses <jakedinero@protonmail.com> Co-authored-by: Moses <103143573+Defi-Moses@users.noreply.github.com> Co-authored-by: Defi-Moses <Defi-Moses@users.noreply.github.com> Co-authored-by: aureliusbtc <82057759+aureliusbtc@users.noreply.github.com>

ChiTimesChi added 2 commits April 1, 2025 16:41

chore: fix existing documentation

22051a7

fix: restrict fromAmount type to string in exported parameters

3bc0178

ChiTimesChi requested review from aureliusbtc and trajan0x as code owners April 1, 2025 15:49

github-actions bot added Sol Typescript size/s labels Apr 1, 2025

vercel bot had a problem deploying to Preview April 1, 2025 15:49 Failure

ChiTimesChi merged commit 28ef655 into master Apr 1, 2025
37 of 39 checks passed

ChiTimesChi deleted the fix/sdk-intent-parameters branch April 1, 2025 17:16

coderabbitai bot mentioned this pull request Apr 1, 2025

fix(sdk-router): add decimals to intent steps #3646

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(sdk-router): restrict `fromAmount` to `string` in the exported intent parameters #3645

fix(sdk-router): restrict `fromAmount` to `string` in the exported intent parameters #3645

Uh oh!

Uh oh!

Uh oh!

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Assets Changed:

Assets Changed:

Uh oh!

Uh oh!

fix(sdk-router): restrict fromAmount to string in the exported intent parameters #3645

fix(sdk-router): restrict fromAmount to string in the exported intent parameters #3645

Uh oh!

Conversation

Uh oh!

Summary by CodeRabbit

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Walkthrough

Changes

Possibly related PRs

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

Deploying sanguine-fe with Cloudflare Pages

Uh oh!

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Bundle Report

Affected Assets, Files, and Routes:

Assets Changed:

Assets Changed:

Uh oh!

Uh oh!

fix(sdk-router): restrict `fromAmount` to `string` in the exported intent parameters #3645

fix(sdk-router): restrict `fromAmount` to `string` in the exported intent parameters #3645