initial approach to have possibility to start own supervisor for diff... #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related to #12 |
|
Ok, I've simplified the interface, to set only one name. Than, it should be seen as proposal. What do you think about? |
4d504d8 to
1548007
Compare
|
Added backwards compatibility to original API. |
|
If it works and you'll be ready for catching all possible issues after merge then I can merge your change-set. Did you check that phoenix live reload plugin still works ? |
|
@5HT It works, I have tested and phoenix_live_reload still works. I've added information in README about |
|
Well then thanks and welcome. I'm mergin' and will review code later. |
5HT
added a commit
that referenced
this pull request
Jan 7, 2016
initial approach to have possibility to start own supervisor for diff...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…erent handlers
It is not thought for merge, but the question, why the interface is so inflexible? If you want to change the path, you need to set environment, before starting the fs application (that leads, that on all places, where library is used, developers simply subscribe to cwd, which is default and checking the needed pattern for the path). And, it is not possible to create more, than one.
I think, there should be interface for it, for creating supervisors in own tree.
Simple attemp to add interface with start_link/4 (which get 3 names and path and it is still ugly), but want to try, that it works.
2 changes, which I want to reach:
What do you think about it in general?