8000 Move want_uki() check out of build_uki_profiles() by DaanDeMeyer · Pull Request #3441 · systemd/mkosi · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Move want_uki() check out of build_uki_profiles() #3441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 28, 2025
Merged

Move want_uki() check out of build_uki_profiles() #3441

merged 1 commit into from
Jan 28, 2025

Conversation

DaanDeMeyer
Copy link
Contributor

Otherwise the function is skipped in make_uki() even though it should never be skipped in that case if there are UKI profiles defined.

@DaanDeMeyer
Move want_uki() check out of build_uki_profiles()
d80b96a 
Otherwise the function is skipped in make_uki() even though it should
never be skipped in that case if there are UKI profiles defined.
behrmann
behrmann approved these changes Jan 28, 2025
View reviewed changes
Copy link
Contributor
@behrmann behrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but in the case of UKI profiles being defined, shouldn't then want_uki not always be true? What I mean, should want_uki grow

if context.config.unified_kernel_image_profiles:
    return True

@DaanDeMeyer
Copy link
Contributor Author

LGTM, but in the case of UKI profiles being defined, shouldn't then want_uki not always be true? What I mean, should want_uki grow

No, there might be profiles defined for "if" a UKI is built, but they shouldn't case us to always build a uki

@DaanDeMeyer DaanDeMeyer merged commit c28ee2e into systemd:main Jan 28, 2025
33 of 35 checks passed
@DaanDeMeyer DaanDeMeyer deleted the uki-profiles branch January 28, 2025 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluca bluca bluca approved these changes

@behrmann behrmann behrmann approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DaanDeMeyer @bluca @behrmann
0