8000 feat: Always ensure we create a change set for a run by stack72 · Pull Request #9 · systeminit/actions · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: Always ensure we create a change set for a run #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 25, 2025
Merged

feat: Always ensure we create a change set for a run #9

merged 1 commit into from
Jan 25, 2025

Conversation

stack72
Copy link
Contributor
@stack72 stack72 commented Jan 25, 2025 •
edited
Loading

The thought here is that we don't want users to need to go to the web app to be able to get a change set id - we create it and return it

This PR also:

  • reoders the action to not use trigger
  • Changes the action.yml to remove the items we don't need
  • adds the GitHub actions we need for releasing the action
  • removes the coverage image
  • removes extra files not part of the action
  • reorders the tests to be inside the src for simplier builds

@stack72 stack72 force-pushed the always-create-changeset branch 3 times, most recently from a8b3ca2 to b28c067 Compare January 25, 2025 01:33
@stack72 stack72 requested a review from jkeiser January 25, 2025 01:33
@stack72 stack72 force-pushed the always-create-changeset branch 5 times, most recently from e33904a to 602aeaf Compare January 25, 2025 02:05
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@stack72 stack72 force-pushed the always-create-changeset branch from 602aeaf to bbebfa1 Compare January 25, 2025 02:09
jkeiser
jkeiser reviewed Jan 25, 2025
View reviewed changes
Copy link
Contributor
@jkeiser jkeiser left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love the changes in general and am thrilled at having sane repository to work with :) Couple of comments to discuss; I'm more worried about usability of removing the action name than anything.

@stack72 stack72 force-pushed the always-create-changeset branch from bbebfa1 to b80ccac Compare January 25, 2025 18:17
@stack72 stack72 force-pushed the always-create-changeset branch from b80ccac to 78b33e6 Compare January 25, 2025 18:18
jkeiser
jkeiser reviewed Jan 25, 2025
View reviewed changes
jkeiser
jkeiser reviewed Jan 25, 2025
View reviewed changes
@stack72 stack72 force-pushed the always-create-changeset branch from 78b33e6 to 5f33192 Compare January 25, 2025 18:28
jkeiser
jkeiser reviewed Jan 25, 2025
View reviewed changes
@stack72 stack72 merged commit c37ebdc into main Jan 25, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkeiser jkeiser jkeiser left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stack72 @jkeiser
0