8000 feat(luminork): Add support for autogenerating SDKs and docs by stack72 · Pull Request #6103 · systeminit/si · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(luminork): Add support for autogenerating SDKs and docs #6103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2025

Conversation

stack72
Copy link
Contributor
@stack72 stack72 commented May 13, 2025

The first iteration of this used direct path structures. Now to generate the SDKs, we do the following:

buck2 run //generated-sdks:update_sdks

This generates the openapi.json file and then uses that file as inputs for generating the SDKs

To generate the docs:

buck2 run //app/docs:generate_api_docs

This will ensure that the correct openapi.json file has been generated and then updates the sources for the public-api.md file

@github-actions github-actions bot added A-docs Area: Project documentation A-auth A-luminork labels May 13, 2025
Copy link
github-actions bot commented May 13, 2025

Dependency Review

✅ No vulnerabilities or OpenSSF Scorecard issues found.

Scanned Files

None

@stack72 stack72 force-pushed the buckify-openapi-spec branch 3 times, most recently from 2ffcb84 to 436fa98 Compare May 13, 2025 01:12
@stack72 stack72 requested review from fnichol and britmyerss May 13, 2025 01:12
The first iteration of this used direct path structures. Now to generate the SDKs, we do the following:

```
buck2 run //generated-sdks:update_sdks
```

This generates the openapi.json file and then uses that file as inputs for generating the SDKs

To generate the docs:

```
buck2 run //app/docs:generate_api_docs
```

This will ensure that the correct openapi.json file has been generated and then updates the sources for the public-api.md file
Fixup
FIXUP
@stack72 stack72 force-pushed the buckify-openapi-spec branch from 436fa98 to aea90d1 Compare May 13, 2025 14:01
@johnrwatson johnrwatson self-requested a review May 14, 2025 13:44
Copy link
Contributor
@johnrwatson johnrwatson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@stack72 stack72 added this pull request to the merge queue May 14, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 14, 2025
@stack72 stack72 added this pull request to the merge queue May 14, 2025
Merged via the queue into main with commit e361540 May 14, 2025
11 checks passed
@stack72 stack72 deleted the buckify-openapi-spec branch May 14, 2025 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-auth A-docs Area: Project documentation A-luminork
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0