chore(dal): Single si_db::Error type, use si_db::* types from dal #6114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8000
Dependency Review✅ No vulnerabilities or OpenSSF Scorecard issues found.Scanned FilesNone |
aca8fc6 to
bced0d6
Compare
nickgerace
reviewed
May 14, 2025
| Err(err) => return Err(ChangeSetError::User(err)), | ||
| } | ||
| } | ||
| HistoryActor::User(user_pk) => User::get_by_pk(ctx, *user_pk).await?.pk(), |
Comment on lines
-31
to
-34
| // TODO TransactionsError really needs to be moved to a common place accessible here and in dal | ||
| #[remain::sorted] | ||
| #[derive(Debug, Error, strum::EnumDiscriminants)] | ||
| pub enum BaseTransactionsError { |
Comment on lines
+40
to
+42
| #[remain::sorted] | ||
| #[derive(thiserror::Error, Debug)] | ||
| pub enum Error { |
Comment on lines
+13
to
+16
| // TODO TransactionsError really needs to be moved to a common place accessible here and in dal | ||
| #[remain::sorted] | ||
| #[derive(Debug, Error, strum::EnumDiscriminants)] | ||
| pub enum SiDbTransactionsError { |
There was a problem hiding this comment.
Mainly because one thing at a time, honestly :) I think the right thing to do in the end is to call this TransactionsError and remove dal::TransactionsError, because most of the things returning that error aren't actually transactions ... but that will be better done by itself.
nickgerace
approved these changes
May 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a sort of "cleanup PR" after the work to move DB types from dal into the si-db crate:
use si_db::UserinsteadTesting