feat(dal): Allow arrays to subscribe to multiple values #6111

jkeiser · 2025-05-14T00:48:23Z

This PR allows you to subscribe to multiple values from a single array, and will put them together into a single array. It has two specific changes:

Allows multiple subscriptions to array values
- Changes AttributeValue::subscribe() to AttributeValue::set_to_subscriptions(), setting multiple subscriptions at once
- Adds keepExistingSubscriptions option to PUT /component/:componentId/attributes to make it easier for the "add subscription" button to be built for arrays
Uses si:normalizeToArray instead of si:identity when the subscriber is an array, to uplevel single values

It will return an error if you attempt to assign multiple subscriptions to a non-array value.

Factor Budget

Made the tests super ergonomic with some attribute::value::set/subscribe/get helpers, letting you pass component names and attribute paths to reference things
AttributeValue::list_arguments_for_id -> list_arguments (there is no other variant)

Testing

Test that subscribing from an array to an array flows the values through
Test that subscribing to a single value from an array uplevels it to an array
Test that subscribing to multiple scalars flows the values through as an array
Manually test that subscriptions still work for current values

github-actions · 2025-05-14T00:50:04Z

Dependency Review

✅ No vulnerabilities or OpenSSF Scorecard issues found.

Scanned Files

None

jkeiser · 2025-05-14T15:05:18Z

/try

github-actions · 2025-05-14T15:05:33Z

Okay, starting a try! I'll update this comment once it's running...\n
🚀 Try running here! 🚀

jhelwig · 2025-05-14T16:10:30Z

It's a bit difficult to find in the wall of output, but there's a failing test: integration_test::materialized_views::incoming_connections

The formatting doesn't copy well out of BuildKite...

Message:  assertion failed: `(left == right)`
--
 
Diff < left / right > :
[
Prop {
from_component_id: WeakReference {
kind: Component,
id: ReferenceId(
ComponentId(
<                    "01JV7P0XAWY6NBJ5JVSMDAH7Z8",
<                ),
<            ),
<            _kind: PhantomData<si_frontend_mv_types::reference::weak::markers::Component>,
<        },
<        from_attribute_value_id: AttributeValueId(
<            "01JV7P0XGC86E6QGGK95BBNWKQ",
<        ),
<        from_attribute_value_path: "/si/name",
<        from_prop_id: PropId(
<            "01JV7NRZDMESFM62VHD1KCXW9H",
<        ),
<        from_prop_path: "/root/si/name",
<        to_component_id: WeakReference {
<            kind: Component,
<            id: ReferenceId(
<                ComponentId(
<                    "01JV7P0YMJJB7VSJD6GT94Y9P0",
<                ),
<            ),
<            _kind: PhantomData<si_frontend_mv_types::reference::weak::markers::Component>,
<        },
<        to_prop_id: PropId(
<            "01JV7NRZDMESFM62VHD1KCXW9H",
<        ),
<        to_prop_path: "/root/si/name",
<        to_attribute_value_id: AttributeValueId(
<            "01JV7P0YMPCAZRRPWKD5KAJH5D",
<        ),
<        to_attribute_value_path: "/si/name",
<    },
<    Prop {
<        from_component_id: WeakReference {
<            kind: Component,
<            id: ReferenceId(
<                ComponentId(
"01JV7P0YHDBC81YQRJ2250XCJ0",
),
),
_kind: PhantomData<si_frontend_mv_types::reference::weak::markers::Component>,
},
from_attribute_value_id: AttributeValueId(
"01JV7P0YJ933ZR5TNBYW4KTAWH",
),
from_attribute_value_path: "/domain/name",
from_prop_id: PropId(
"01JV7NRZKFKTB1PRJGJ5T2X241",
),
from_prop_path: "/root/domain/name",
to_component_id: WeakReference {
kind: Component,
id: ReferenceId(
ComponentId(
"01JV7P0YMJJB7VSJD6GT94Y9P0",
),
),
_kind: PhantomData<si_frontend_mv_types::reference::weak::markers::Component>,
},
to_prop_id: PropId(
<            "01JV7NRZFFR8WG3AWQVH998Y72",
>            "01JV7NRZDMESFM62VHD1KCXW9H",
),
<        to_prop_path: "/root/domain/name",
>        to_prop_path: "/root/si/name",
to_attribute_value_id: AttributeValueId(
<            "01JV7P0YMR5EKPGJ2SHW7VHZA0",
>            "01JV7P0YMPCAZRRPWKD5KAJH5D",
),
<        to_attribute_value_path: "/domain/name",
>        to_attribute_value_path: "/si/name",
},
Socket {
from_component_id: WeakReference {
kind: Component,
id: ReferenceId(
ComponentId(
"01JV7P0YHDBC81YQRJ2250XCJ0",
),
),
_kind: PhantomData<si_frontend_mv_types::reference::weak::markers::Component>,
},
from_attribute_value_id: AttributeValueId(
"01JV7P0YHDBC81YQRJ2250XCJ4",
),
from_attribute_value_path: "",
from_socket_id: OutputSocketId(
"01JV7NRZKWRXYJWF5E72013J0W",
),
from_socket_name: "one",
to_component_id: WeakReference {
kind: Component,
id: ReferenceId(
ComponentId(
"01JV7P0YMJJB7VSJD6GT94Y9P0",
),
),
_kind: PhantomData<si_frontend_mv_types::reference::weak::markers::Component>,
},
to_socket_id: InputSocketId(
"01JV7NRZG2GEM9A3ZWEG587GQV",
),
to_socket_name: "one",
to_attribute_value_id: AttributeValueId(
"01JV7P0YMK36A8TQX34T0YNKRY",
),
to_attribute_value_path: "",
},
]
 
 
Location: lib/dal/tests/integration_test/materialized_views.rs:403

jkeiser · 2025-05-14T16:34:30Z

/try

github-actions · 2025-05-14T16:34:49Z

Okay, starting a try! I'll update this comment once it's running...\n
🚀 Try running here! 🚀

lib/sdf-server/src/service/v2/component/attributes.rs

lib/dal/src/attribute/value.rs

lib/dal/src/attribute/value/subscription.rs

jkeiser requested a review from jhelwig May 14, 2025 00:48

github-actions bot added A-sdf Area: Primary backend API service [Rust] A-dal A-web A-dal-test labels May 14, 2025

jkeiser force-pushed the jkeiser/append-subscriptions branch from f39c5c3 to 5dd2c40 Compare May 14, 2025 00:49

jkeiser force-pushed the jkeiser/append-subscriptions branch 2 times, most recently from c71870e to 8b8a9d3 Compare May 14, 2025 04:07

jkeiser force-pushed the jkeiser/append-subscriptions branch from 8b8a9d3 to 0153657 Compare May 14, 2025 16:33

jkeiser force-pushed the jkeiser/append-subscriptions branch 2 times, most recently from 78f7787 to b1faaca Compare May 14, 2025 18:17

jhelwig requested changes May 14, 2025

View reviewed changes

lib/sdf-server/src/service/v2/component/attributes.rs Outdated Show resolved Hide resolved

lib/dal/src/attribute/value.rs Show resolved Hide resolved

lib/dal/src/attribute/value/subscription.rs Outdated Show resolved Hide resolved

Allow arrays to subscribe to multiple scalars

7d11b60

jkeiser force-pushed the jkeiser/append-subscriptions branch from b1faaca to 7d11b60 Compare May 14, 2025 21:45

jhelwig approved these changes May 15, 2025

View reviewed changes