8000 chore: flake update by sprutton1 · Pull Request #6123 · systeminit/si · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore: flake update #6123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2025
Merged

chore: flake update #6123

merged 1 commit into from
May 15, 2025

Conversation

sprutton1
Copy link
Contributor

Specifically to get the latest buck2. Needed to pull in a later nodejs as 18 is deprecated. I will confirm this locally to ensure we have no breakages.

Copy link

Dependency Review

✅ No vulnerabilities or OpenSSF Scorecard issues found.

Scanned Files

None

@sprutton1
Copy link
Contributor Author

/try

Copy link
github-actions bot commented May 15, 2025

Okay, starting a try! I'll update this comment once it's running...\n
🚀 Try running here! 🚀

@sprutton1 sprutton1 enabled auto-merge May 15, 2025 17:17
Copy link
Contributor
@adamhjk adamhjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

long live node 20! :)

lgtm

@sprutton1 sprutton1 added this pull request to the merge queue May 15, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 15, 2025
@sprutton1 sprutton1 enabled auto-merge May 15, 2025 18:23
Copy link
Contributor
@fnichol fnichol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming everything builds (primarily app/web), then I'd expect we're good.

The only catch is that nothing in our current merge queue pipeline builds app/web so it'll be hard to tell without checking seperately

@sprutton1
Copy link
Contributor Author

/try

Copy link
github-actions bot commented May 15, 2025

Okay, starting a try! I'll update this comment once it's running...\n
🚀 Try running here! 🚀

@sprutton1 sprutton1 added this pull request to the merge queue May 15, 2025
Merged via the queue into main with commit df590b5 May 15, 2025
38 checks passed
@sprutton1 sprutton1 deleted the nix/flake-update branch May 15, 2025 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0