Performance testing/investigation #6140
Draft
+53
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or OpenSSF Scorecard issues found.Scanned FilesNone |
|
/try |
|
Okay, starting a try! I'll update this comment once it's running...\n |
|
/try |
|
Okay, starting a try! I'll update this comment once it's running...\n |
|
/try |
|
Okay, starting a try! I'll update this comment once it's running...\n |
6ada745 to
fdb7911
Compare
|
/try |
|
Okay, starting a try! I'll update this comment once it's running...\n |
fdb7911 to
ada1005
Compare
|
/try |
|
Okay, starting a try! I'll update this comment once it's running...\n |
|
/try |
|
Okay, starting a try! I'll update this comment once it's running...\n |
3e93312 to
50087af
Compare
|
/try |
|
Okay, starting a try! I'll update this comment once it's running...\n |
… the UI `AttributeValue::update`, and `FuncRunner::run_attribute_value` appear to take substantial amounts of time. This adds additional instrumentation to try to help narrow down exactly where & why.
…value.prepare slowness
…nctions The intrinsic functions are never dispatched to Veritech to run, and the point of a "before function" is to set up the environment that Veritech/Cyclone will use to run the function so that it has access to whatever secrets/config it needs, which means that a before function will never be able to affect how an intrinsic is run.
There is several seconds of unaccounted for time in update_property_editor_value, so this is attempting to help narrow down where that time is being spent.
50087af to
66f7fc4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.