chore(dal): Test if we unintentionally regress node/edge size #6155
8000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or OpenSSF Scorecard issues found.Scanned FilesNone |
af929f5 to
8495d43
Compare
vbustamante
approved these changes
May 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a unit test which will fail if NodeWeight or EdgeWeight gets bigger. It also checks individual NodeWeight sizes so we can get a sense of what's impacting node size.
If you increase the size of one of the individual NodeWeight variants, it can have multiplicative effects beyond just the type you modified: increasing the biggest variants will increase the size of NodeWeight itself, which effectively increases all node sizes (since petgraph reserves space for a NodeWeight, not an individual variant). Increasing smaller node weights will have minimal impact on runtime space requirements.
Testing