8000 feat(dal,edda): Add the MVs necessary for creating, updating, and listing secrets by britmyerss · Pull Request #6160 · systeminit/si · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(dal,edda): Add the MVs necessary for creating, updating, and listing secrets #6160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 20, 2025
Merged

feat(dal,edda): Add the MVs necessary for creating, updating, and listing secrets #6160

merged 1 commit into from
May 20, 2025

Conversation

britmyerss
Copy link
Contributor

This change introduces 4 new MV kinds:

  • SecretList - A list of all created secrets for the change set (triggered by the Secret Category node)
  • Secret - The MV for an individual Secret, with a weak reference to the secret definition
  • SecretDefinitionList - A list of all available secret definitions in the change set (this is triggered by the Schema Category node)
  • SecretDefinition - The MV for an individual SecretDefinition, identified by the PropId (this is triggered when Prop nodes change, so there's a short circuit in Edda to early return if the given Prop isn't for a secret definition)

Many thanks to @jhelwig and @jobelenus for helping me to unwind this!

@github-actions GitHub Actions
Copy link
github-actions bot commented May 19, 2025 •
edited
Loading

Dependency Review

✅ No vulnerabilities or OpenSSF Scorecard issues found.

Scanned Files

None

@britmyerss britmyerss force-pushed the brit/secrets-mv branch 4 times, most recently from f3c06f1 to 7b6ce9e Compare May 19, 2025 23:27
@britmyerss
feat(dal,edda): Add the MVs necessary for creating, updating, and lis…
5cb2d57 
…ting secrets

This change introduces 4 new MV kinds: 
- SecretList - A list of all created secrets for the change set (triggered by the Secret Category node)
- Secret - The MV for an individual Secret, with a weak reference to the secret definition
- SecretDefinitionList - A list of all available secret definitions in the change set (this is triggered by the Schema Category node)
- SecretDefinition - The MV for an individual SecretDefinition, identified by the PropId (this is triggered when Prop nodes change, so there's a short circuit in Edda to early return if the given Prop isn't for a secret definition)
@britmyerss britmyerss added this pull request to the merge queue May 20, 2025
Merged via the queue into main with commit 9acacd9 May 20, 2025
10 checks passed
@britmyerss britmyerss deleted the brit/secrets-mv branch May 20, 2025 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jobelenus jobelenus jobelenus approved these changes

Assignees
No one assigned
Labels
A-dal A-edda
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@britmyerss @jobelenus
0