fix(dal): ensure ec2 qualification runs after create action #2692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors r+ |
si-bors-ng bot
added a commit
that referenced
this pull request
Aug 24, 2023
2692: fix(dal): ensure ec2 qualification runs after create action r=zacharyhamm a=zacharyhamm This adds the `resource` to the `si:qualificationEc2CanRun` function inputs to ensure that we run the qualification again after an EC2 instance has been created. Fixes the warning remaining on the instance about Key Pair creation. Co-authored-by: Zachary Hamm <zack@systeminit.com>
|
bors r- |
|
Canceled. |
This adds the `resource` to the `si:qualificationEc2CanRun` function inputs to ensure that we run the qualification again after an EC2 instance has been created. Fixes the warning remaining on the instance about Key Pair creation.
08973ab to
7ff0b29
Compare
|
bors r+ |
|
🕐 Waiting for PR status (Github check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set. |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the
resourceto thesi:qualificationEc2CanRunfunction inputs to ensure that we run the qualification again after an EC2 instance has been created. Fixes the warning remaining on the instance about Key Pair creation.